Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update multi select toolbars setup #1338

Merged
merged 5 commits into from
Sep 4, 2023
Merged

Update multi select toolbars setup #1338

merged 5 commits into from
Sep 4, 2023

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented Sep 4, 2023

Description

This sets up separate multi-select toolbars for episodes and bookmarks instead of reusing the same toolbar and setting it up based on the selected tab on the podcast details screen.

4ef7ddd is a cherry pick from an unmerged PR to help with testing.

Testing Instructions

Bookmarks enabled

  1. Enable the Patron and Bookmarks feature
  2. Login with a Patron account
  3. Open a podcast
  4. Long press on an episode row
  5. ✅ Notice that the episode multi-select toolbar is shown
  6. Select a few episodes
  7. ✅ Notice that correct episodes are selected
  8. Tap on the Bookmarks tab
  9. Notice that
    • Episodes multi-select toolbar is closed
    • Bookmarks multi-select toolbar is shown
  10. Select a few bookmarks
  11. ✅ Notice that correct bookmarks are selected
  12. Tap on the Episodes tab
  13. ✅ Notice that
    • Bookmarks multi-select toolbar is closed
    • Episodes multi-select toolbar is shown

Bookmarks disabled

  1. Disable the Bookmarks feature
  2. Open a podcast
  3. Long press on an episode row
  4. ✅ Notice that the episode multi-select toolbar is shown
  5. Select a few episodes
  6. ✅ Notice that correct episodes are selected

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@ashiagr ashiagr requested a review from a team as a code owner September 4, 2023 07:31
Base automatically changed from update/fix-merge to main September 4, 2023 07:55
@ashiagr ashiagr merged commit ec22b40 into main Sep 4, 2023
@ashiagr ashiagr deleted the fix/toolbars-setup branch September 4, 2023 09:41
@ashiagr ashiagr added this to the 7.47 ❄️ milestone Sep 4, 2023
ashiagr added a commit that referenced this pull request Sep 6, 2023
ashiagr added a commit that referenced this pull request Sep 6, 2023
ashiagr added a commit that referenced this pull request Sep 6, 2023
@ashiagr ashiagr mentioned this pull request Sep 6, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants