Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the 7.45 release we've seen a significant increase in ANRs: #1314. This PR avoids the ANRs by addressing part of the underlying issue.
Note that this PR is targeting a new
7.45.1
hotfix branch because I think this should be a hotfix since it is causing thousands of ANRs a day. For that reason, I am keeping this PR small and lean (basically the simplest changes that address the ANRs), and I will open a separate PR that builds on this for a betafix release (#1316).This fix is basically just to make sure that we avoid iterating through the multiselect items when we select or deselect all of the multiselect items.
Testing Instructions
Screen.Recording.2023-08-28.at.5.12.06.PM.mov
Screen.Recording.2023-08-28.at.5.26.53.PM.mov
Checklist
./gradlew spotlessApply
to automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xml