Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid crash when accessing and dismissing episode details from up next queue #1300

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Avoid crash when accessing and dismissing episode details from up next queue #1300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...sts/src/main/java/au/com/shiftyjelly/pocketcasts/podcasts/view/episode/EpisodeFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ class EpisodeFragment : BaseFragment() {
super.onDestroyView()
if (!viewModel.isFragmentChangingConfigurations) {
analyticsTracker.track(AnalyticsEvent.EPISODE_DETAIL_DISMISSED, mapOf(AnalyticsProp.Key.SOURCE to episodeViewSource.value))
podcastAndEpisodeDetailsCoordinator.onEpisodeDetailsDismissed()
podcastAndEpisodeDetailsCoordinator.onEpisodeDetailsDismissed?.invoke()
}
webView.cleanup()
webView = null
Expand Down
2 changes: 1 addition & 1 deletion .../au/com/shiftyjelly/pocketcasts/podcasts/viewmodel/PodcastAndEpisodeDetailsCoordinator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ import javax.inject.Singleton

@Singleton
class PodcastAndEpisodeDetailsCoordinator @Inject constructor() {
lateinit var onEpisodeDetailsDismissed: () -> Unit
var onEpisodeDetailsDismissed: (() -> Unit)? = null
}