Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable selecting text in logs #1298

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Enable selecting text in logs #1298

merged 2 commits into from
Aug 22, 2023

Conversation

mchowning
Copy link
Contributor

@mchowning mchowning commented Aug 21, 2023 •
edited
Loading

Description

Makes it possible to select text and copy it from the in-app logs viewer.

Testing Instructions

  1. Go to the in-app logs viewer ("Profile" → ⚙️ → "Help & feedback" → logs icon on the top of the screen)
  2. Long press somewhere in the logs to start selecting text

Screenshots or Screencast

Screen.Recording.2023-08-21.at.3.28.44.PM.mov

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

@mchowning mchowning marked this pull request as ready for review August 21, 2023 19:32
@mchowning mchowning requested a review from a team as a code owner August 21, 2023 19:32
geekygecko
geekygecko approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@geekygecko geekygecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change, I hadn't realised a user couldn't select the text.

Thanks for teaching me about SelectionContainer!

@geekygecko geekygecko merged commit 2bde768 into main Aug 22, 2023
@geekygecko geekygecko deleted the add/copy-from-logs branch August 22, 2023 01:31
@ashiagr ashiagr added this to the 7.47 ❄️ milestone Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekygecko geekygecko geekygecko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.47
Development

Successfully merging this pull request may close these issues.
3 participants
@mchowning @geekygecko @ashiagr