Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding logs to Automotive #1277

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Adding logs to Automotive #1277

merged 2 commits into from
Aug 14, 2023

Conversation

geekygecko
Copy link
Member

@geekygecko geekygecko commented Aug 14, 2023

Description

This change adds the logs to the Automotive version of the app to help us debug issues one of our Automotive partners is having.

Thanks @ashiagr, this uses the log viewer from your PR. I didn't include the encrypted upload in this version and instead will ask for a screenshot. To help with this I have scrolled to the bottom of the logs as this is where the latest logs are.

I also added a link to our "Help & Feedback" section.

Testing Instructions

  1. Tap the settings cog
  2. Scroll to the bottom of the page and tap "About"
  3. Scroll to the bottom of the page and tap "Help & Feedback"
  4. ✅ Verify it shows a link to the support website
  5. Tap the back arrow
  6. Tap "Logs"
  7. ✅ Verify the logs are shown

Screenshots and Screencast

Screenshot_20230814_101928

Screen.Recording.2023-08-14.at.10.17.18.am.mov

@geekygecko geekygecko marked this pull request as ready for review August 14, 2023 01:09
@geekygecko geekygecko requested a review from a team as a code owner August 14, 2023 01:09
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! 👍

...I have scrolled to the bottom of the logs as this is where the latest logs are.

That's a great idea. I've been meaning to add some buttons to scroll to top/bottom on the phone. I'll finally stop putting that off and do that now to make it even more convenient on the phone. (#1279)

@mchowning mchowning merged commit b003142 into main Aug 14, 2023
@mchowning mchowning deleted the task/automotive-logs branch August 14, 2023 21:44
@ashiagr ashiagr added this to the 7.46 milestone Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants