Settings Sync - convert remaining settings to UserSettings #1271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes the automotive settings for subscribing to played podcasts, showing played podcasts, and the setting for the last played list into UserSettings.
In addition, this fixes a bug whereby auto play on automotive was not updating the autoPlay user setting. It was just updating the persisted setting directly, which meant the UserSetting's flow was not updated and would not reflect the new value until the app was restarted. I introduced this bug when I refactored the auto play setting to be a
UserSetting
(#1213), so it never got released.Testing Instructions
1. Subscribing to played podcasts
On the automotive app, ensure that toggling the subscribe to played podcast setting
2. Showing played podcasts
On the automotive app, ensure that togglign the show played episodes setting
3. Auto play (implicitly testing the last-played-list setting)
On both the automotive and phone apps, ensure that when playing a podcast episode with remaining unplayed episodes, completing that episode will:
Checklist
./gradlew spotlessApply
to automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xml