Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert privacy settings into UserSettings #1247

Conversation

mchowning
Copy link
Contributor

@mchowning mchowning commented Aug 7, 2023

Description

Updating the privacy settings to be UserSettings

Testing Instructions

1. Tracks

  1. Verify that "Analytics" toggle in the Privacy settings defaults to on
  2. Verify that tracks come through when the "Analytics" toggle is on, and that they do not come through when it is off.

2. Crash Reports

  1. Make a change to the app so you can trigger a recognizable crash by tapping some button
  2. Freshly install a release build
  3. Log into an account
  4. Verify that in the privacy setting for "Crash reports" defaults to off
  5. Turn this toggle "on"
  6. Leave "Link your account to crashes" to be "off"
  7. Trigger a crash
  8. Toggle "Link your account to crashes" to be "on"
  9. Trigger a crash
  10. Toggle "Crash reports" to off
  11. Trigger a crash
  12. Reopen the app
  13. Check Sentry and confirm that you there are only two matching crash events: the first one should not have the email linked, and the second one should have the email linked

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

@mchowning mchowning requested a review from a team as a code owner August 7, 2023 19:14
Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good code-wise so I'm approving the PR but I am unable to test crash logs. I can't install the release build because of CIRCULAR REFERENCE error:

Screenshot 2023-08-08 at 9 24 09 PM

This can be addressed in a separate PR.

@mchowning
Copy link
Contributor Author

mchowning commented Aug 8, 2023

Changes look good code-wise so I'm approving the PR but I am unable to test crash logs. I can't install the release build because of CIRCULAR REFERENCE error.

Well that's not good. For some reason I'm not having any issue creating a release build. Would you mind cleaning and/or building from the command line just to make sure this isn't an Android Studio caching issue?

@mchowning mchowning merged commit 407a945 into feature/sync-settings-refactor Aug 8, 2023
@mchowning mchowning deleted the update/refactor-settings-for-sync_privacy branch August 8, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants