Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make auto add to up next settings a UserSetting #1240

Conversation

mchowning
Copy link
Contributor

Description

This updates the auto add to up next limit and behavior to each be a UserSetting

Testing Instructions

For the Auto Add to Up Next setting, test the "Aut add limit" and "If limit reached" setting by:

  1. Fresh install the app
  2. Verify that the setting has the same default value that it had before
  3. Change the setting to a new value
  4. Force close the app
  5. Verify that the setting has retained the new value
  6. Verify that the app's behavior reflects the updated setting value. Note that you can force new episodes to be received from the "Developer Settings" section by tapping "Delete first episodes" and then tapping "force refresh". When testing whether the up next queue limit be aware that "delete first episodes" will remove items from your queue (i.e., if you set your queue to the max, and then tap delete first episodes, your queue may no longer be at the max).

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml

mchowning added 30 commits July 27, 2023 13:52
Otherwise, the UserSetting flow never gets updated
@mchowning mchowning requested a review from a team as a code owner August 4, 2023 14:30
Base automatically changed from update/refactor-settings-for-sync_auto-archive to update/refactor-settings-for-sync_appearance August 7, 2023 05:37
Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests pass.

Thanks for the extra test details that you include to make testing and reviewing easier.

Base automatically changed from update/refactor-settings-for-sync_appearance to feature/sync-settings-refactor August 7, 2023 14:30
…into update/refactor-settings-for-sync_auto-add-to-up-next
…into update/refactor-settings-for-sync_auto-add-to-up-next
@mchowning mchowning merged commit 39f8335 into feature/sync-settings-refactor Aug 7, 2023
@mchowning mchowning deleted the update/refactor-settings-for-sync_auto-add-to-up-next branch August 7, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants