-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make auto add to up next settings a UserSetting
#1240
Merged
mchowning
merged 48 commits into
feature/sync-settings-refactor
from
update/refactor-settings-for-sync_auto-add-to-up-next
Aug 7, 2023
Merged
Make auto add to up next settings a UserSetting
#1240
mchowning
merged 48 commits into
feature/sync-settings-refactor
from
update/refactor-settings-for-sync_auto-add-to-up-next
Aug 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, the UserSetting flow never gets updated
…into update/refactor-settings-for-sync_notifications
Base automatically changed from
update/refactor-settings-for-sync_auto-archive
to
update/refactor-settings-for-sync_appearance
August 7, 2023 05:37
ashiagr
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests pass.
Thanks for the extra test details that you include to make testing and reviewing easier.
Base automatically changed from
update/refactor-settings-for-sync_appearance
to
feature/sync-settings-refactor
August 7, 2023 14:30
…into update/refactor-settings-for-sync_auto-add-to-up-next
…into update/refactor-settings-for-sync_auto-add-to-up-next
mchowning
deleted the
update/refactor-settings-for-sync_auto-add-to-up-next
branch
August 7, 2023 15:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates the auto add to up next limit and behavior to each be a
UserSetting
Testing Instructions
For the Auto Add to Up Next setting, test the "Aut add limit" and "If limit reached" setting by:
Checklist
./gradlew spotlessApply
to automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xml