Bookmarks - Add search on podcast page #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashiagr
commented
Jul 27, 2023
Comment on lines
+83
to
+92
| @Composable | ||
| fun SearchView( | ||
| bookmarkHeader: BookmarkHeader, | ||
| modifier: Modifier = Modifier, | ||
| ) { | ||
| val hintText = stringResource(id = LR.string.bookmarks_search) | ||
| AndroidView( | ||
| modifier = modifier, | ||
| factory = { context -> | ||
| EpisodeSearchView(context).apply { |
There was a problem hiding this comment.
As we haven't moved to material3 yet, which includes a search bar component for Compose, I have reused the existing search component in the Compose view.
Comment on lines
67
to
73
| """SELECT bookmarks.* | ||
| FROM bookmarks | ||
| LEFT JOIN podcast_episodes ON bookmarks.episode_uuid = podcast_episodes.uuid | ||
| WHERE bookmarks.podcast_uuid = :podcastUuid | ||
| AND UPPER(bookmarks.title) LIKE UPPER(:title) | ||
| OR UPPER(podcast_episodes.title) LIKE UPPER(:title) | ||
| AND deleted = :deleted""" |
There was a problem hiding this comment.
Searching for both episode and bookmark titles while searching bookmarks for a podcast.
geekygecko
approved these changes
Jul 28, 2023
...les/services/model/src/main/java/au/com/shiftyjelly/pocketcasts/models/db/dao/BookmarkDao.kt
Outdated
Show resolved
Hide resolved
...src/main/java/au/com/shiftyjelly/pocketcasts/podcasts/helper/search/BookmarkSearchHandler.kt
Outdated
Show resolved
Hide resolved
...src/main/java/au/com/shiftyjelly/pocketcasts/podcasts/helper/search/BookmarkSearchHandler.kt
Outdated
Show resolved
Hide resolved
…casts/models/db/dao/BookmarkDao.kt Co-authored-by: Philip Simpson <[email protected]>
ashiagr
force-pushed
the
task/podcast-page-bookmarks-search
branch
from
9875a3d to
0bd594e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds bookmark search on the podcast page.
Testing Instructions
Podcast DetailspageScreenshots or Screencast
search.mp4
Checklist
./gradlew spotlessApplyto automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xmlI have tested any UI changes...