Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable swipe up in now playing landscape #1209

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented Jul 26, 2023

Description

Fixes: Swiping up to get to "Up Next" doesn't work when unfolded (p1690329518000709-slack-C028JAG44VD)
Test Device : Pixel Fold

Testing Instructions

  1. Open the app on Pixel Fold emulator - landscape mode
  2. Play an episode
  3. Go to Now Playing
  4. Swipe up
  5. Notice that Up Next is shown
  6. Repeat steps 3-6 after fold/ unfold phone
  7. Notice that Up Next is still shown

** The issue is not limited to foldable devices. Swiping up to get to "Up Next" on Now Playing never worked in landscape mode, and I just enabled it.

Screenshots or Screencast

up.next.mp4

I also tested that the screen is not shown for Automotive or Android Auto so it does not affect those platforms.

Automotive Android Auto
Screenshot_20230726_112836 Screenshot 2023-07-26 at 11 36 25 AM

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@ashiagr ashiagr requested a review from a team as a code owner July 26, 2023 07:36
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks so much for fixing this!

FYI: I did push a changelog update to this branch.

@mchowning mchowning enabled auto-merge (squash) July 26, 2023 18:39
@mchowning mchowning merged commit 28b7fe8 into main Jul 26, 2023
@mchowning mchowning deleted the fix/support-now-playing-up-swipe-landscape branch July 26, 2023 19:10
@ashiagr ashiagr added this to the 7.45 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants