Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add share option to multiselect menu #1191

Merged
merged 3 commits into from
Jul 24, 2023

Conversation

mchowning
Copy link
Contributor

@mchowning mchowning commented Jul 21, 2023

Description

This adds a share option to the multiselect menus as requested in the https://github.com/Automattic/pocket-casts-android/discussions/1168 discussion.

Related iOS PR: Automattic/pocket-casts-ios#969

Testing Instructions

Showing the new option for previous users

  1. Checkout and run main
  2. Go to any podcast and long press any episode
  3. Tap "..."
  4. Tap the pencil icon
  5. Reorder and tap "Done"
  6. Run this branch
  7. Go to any podcast and long press an episode
  8. Tap "..."
  9. ✅ "Share" should appear

Testing share action

  1. Go to any podcast and long press a single episode
  2. Tap "..."
  3. Tap "Share"
  4. ✅ The share sheet should appear
  5. Dismiss it
  6. Select more episodes
  7. ✅ "Share" should not be available (only sharing a single episode is available)

Reordering

  1. Go to any podcast and long press a single episode
  2. Tap "..."
  3. Tap the pencil icon
  4. Move "Share" to be one of the first two actions
  5. Tap "Done"
  6. ✅ Share should be displayed on the action bar
  7. Tap it
  8. ✅ The share sheet should appear
  9. Dismiss it
  10. Select more episodes
  11. ✅ The share button will be replaced by the next available action
  12. Tap "..." and then the pencil icon
  13. Move "Share" to below
  14. Tap "Done"
  15. ✅ "Share" should not be available as you have multiple selected episodes

User Episodes

  1. Go to Files and long press one of your files
  2. ✅ Observe that the share option does not appear in either the toolbar or the overflow menu

Events

Sharing

  1. Go to any podcast and long press any episode
  2. Tap Share
  3. ✅ When showing the share sheet you should see a podcast_shared event with "type": "episode" and "source": "multi_select"].

Reordering

  1. To to any podcast and long press any episode
  2. Tap "..." and then the pencil icon
  3. Move the share action
  4. ✅ You should see a multi_select_view_overflow_menu_rearrange_action_moved event with an "action": "share" property.

Screenshots or Screencast

Screen.Recording.2023-07-21.at.5.11.57.PM.mov

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

@mchowning mchowning marked this pull request as ready for review July 21, 2023 21:16
@mchowning mchowning requested a review from a team as a code owner July 21, 2023 21:16
Copy link
Member

@geekygecko geekygecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked well for me. Good work!

@geekygecko geekygecko merged commit a569c20 into add/share-swipe-action Jul 24, 2023
@geekygecko geekygecko deleted the add/share-multi-select-option branch July 24, 2023 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants