Catch out of bounds exception when moving shelf items #1155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a quick fix for a crash that can occur when adjusting the shelf items on the full screen player. I've seen this a fair number of times myself and it looks like around 150 other people have encountered it according to Sentry.
Testing Instructions
I can't recreate this with 100% reliability, but it seems to occur about half the time when I try to move the shelf items on the Now Playing screen immediately after doing a fresh install of the app.
Screenshots or Screencast
This is a video of me recreating the crash without the fix from this PR.
Screen.Recording.2023-07-05.at.12.47.07.PM.mov
Checklist
modules/services/localization/src/main/res/values/strings.xml