Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

+ - 1 min Custom Increments on the Sleep timer #1144

Merged
merged 3 commits into from
Jul 4, 2023
Merged

+ - 1 min Custom Increments on the Sleep timer #1144

merged 3 commits into from
Jul 4, 2023

Conversation

CalebKL
Copy link
Contributor

@CalebKL CalebKL commented Jul 3, 2023

Description

This PR adds +-1 increments if the custom timer is <5.
Fixes # N/A

Testing Instructions

  1. Tap on the Discover tab
  2. Tap on any random podcast and hit play
  3. Click on Sleep timer.
  4. Click on - +.
  5. If the Custom timer is below 5, it reduces /increases by 1 min

Screenshots or Screencast

increments.mp4

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@CalebKL CalebKL requested a review from a team as a code owner July 3, 2023 09:09
@CalebKL CalebKL force-pushed the plus1-minus1-increments branch from 86a6087 to 782a16f Compare July 3, 2023 10:43
ashiagr
ashiagr approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm ❤️

@ashiagr ashiagr enabled auto-merge July 4, 2023 04:14
@ashiagr ashiagr added this to the 7.43 milestone Jul 4, 2023
@ashiagr ashiagr merged commit 9c6091a into Automattic:main Jul 4, 2023
@CalebKL CalebKL deleted the plus1-minus1-increments branch July 4, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashiagr ashiagr ashiagr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.43
Development

Successfully merging this pull request may close these issues.
2 participants
@CalebKL @ashiagr