Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding +1 Minute Timer #1139

Merged
merged 9 commits into from
Jul 3, 2023
Merged

Conversation

CalebKL
Copy link
Contributor

@CalebKL CalebKL commented Jun 30, 2023

Description

This PR adds +1 Minute to sleep timer. Instead of the minimum set time as 5 min, a user can now set up 1 min as the least time.
The layout on the +1 and +5 was changed so as to avoid more thumb reach.
Fixes # N/A

Testing Instructions

  1. Tap on the Discover tab
  2. Tap on any random podcast and hit play
  3. Set Sleep timer.
  4. Click on 5 minute timer.
  5. Click on the timer again.
  6. Add 1 Minute

Screenshots or Screencast

splitminute

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@CalebKL CalebKL requested a review from a team as a code owner June 30, 2023 19:45
Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @Mzazi25!

Can you add a changelog for it?

@CalebKL
Copy link
Contributor Author

CalebKL commented Jul 3, 2023

@ashiagr Done

@ashiagr ashiagr enabled auto-merge July 3, 2023 07:57
@ashiagr ashiagr merged commit ee7fae3 into Automattic:main Jul 3, 2023
@ashiagr ashiagr added this to the 7.43 milestone Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants