Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use regular icon for launcher by default #1079

Merged
merged 2 commits into from
Jun 14, 2023

Conversation

mchowning
Copy link
Contributor

@mchowning mchowning commented Jun 14, 2023

Description

With the end of June coming up, this updates the app to again use the regular Pocket Casts icon by default (follow-up to #997). The Pride icon may still be selected by a user under Profile → ⚙️ → Appearance.

Note
This change is targeting the release/7.41 release branch. We should update the release notes to include this.

Testing Instructions

A. Default icon only

  1. Install a release build of the app without the changes in this PR
  2. Observe the app icon is the pride icon
  3. Install a release build of the app with the changes in this PR
  4. Observe the app icon is the default icon
  5. Under Profile → ⚙️ → Appearance, select the Pride icon
  6. Observe that the app launcher contains both the default icon and the Pride icon

B. Selected non-default icon

  1. Install a release build of the app without the changes in this PR
  2. Under Profile → ⚙️ → Appearance, select any icon other than the default Pocket Casts icon or the Pride icon
  3. Observe that the icon you selected and the Pride icon are in the app launcher
  4. Install a release build of the app with the changes in this PR
  5. Observe that the icon you selected and the default Pocket Casts icon are in the app launcher. The Pride icon should not be there.

C. Selected default icon

  1. Install a release build of the app without the changes in this PR
  2. Under Profile → ⚙️ → Appearance, select the default Pocket Casts icon or the Pride icon
  3. Observe that the default Pocket Casts icon and the Pride icon are in the app launcher
  4. Install a release build of the app with the changes in this PR
  5. Observe the app launcher now contains two instances of the default Pocket Casts icon
  6. Open the app
  7. Return to the app launcher and observe that the default Pocket Casts icon is now only there once.

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

The pride icon can still be selected as an option, it just isn't the
default anymore.
@mchowning mchowning added this to the 7.41 ❄️ milestone Jun 14, 2023
@mchowning mchowning requested a review from emilylaguna June 14, 2023 15:05
@mchowning mchowning marked this pull request as ready for review June 14, 2023 15:05
@mchowning mchowning requested a review from a team as a code owner June 14, 2023 15:05
@mchowning mchowning changed the title Make launcher use default icon by default Use regular icon for launcher by default Jun 14, 2023
@mchowning mchowning changed the base branch from main to release/7.41 June 14, 2023 15:07
Copy link
Contributor

@emilylaguna emilylaguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave this a test using the steps in the PR and below and all is working correctly.

  • ✅ Default Icon
    • Installed 7.38 and left the app icon the default
    • Installed 7.39 and verified the default app icon changed
    • Installed this PR and verified the default app icon is reverted
  • ✅ Custom Icon Doesn't Change:
    • Installed 7.38 and set a custom icon
    • Installed 7.39 and verified the custom icon launcher didn't change
    • Installed 7.41 and verified the custom icon launcher didn't change
      • Verified the original launcher icon did change
  • ✅ Revert to default after icon change:
    • Installed 7.38 and left the app icon as the default
    • Installed 7.39 and verified the icon changed
      • Changed the app icon back to the default red one
    • Installed 7.41 and verified the custom icon launcher icon remained the red one
      • Verified the original launcher icon did revert
  • ✅ Change to custom icon after icon change:
    • Installed 7.38 and left the app icon as the default
    • Installed 7.39 and verified the icon changed
      • Changed to a different icon
    • Installed 7.41 and verified the icon remained the custom one
  • ✅ Custom icons:
    • Installed 7.38 and set a custom app icon
    • Installed 7.39 and custom launcher icon stayed the same
    • Installed 7.41 and custom launcher icon stayed the same
  • ✅ Custom icon to custom icon:
    • Installed 7.38 and changed the icon to a custom one
    • Installed 7.39 and verified the icon remained the custom one
      • Changed the app icon again to a custom one
    • Installed 7.41 and verified the icon remained the 2nd custom one

@mchowning mchowning merged commit af2a08b into release/7.41 Jun 14, 2023
@mchowning mchowning deleted the update/update-default-app-icon branch June 14, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants