Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Sentry proguard setting for watch app and add changelog #1068

Merged
merged 5 commits into from
Jun 12, 2023
Merged

Add Sentry proguard setting for watch app and add changelog #1068

merged 5 commits into from
Jun 12, 2023

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented Jun 12, 2023 •
edited
Loading

Initial Project Issue
Project Board

Description

This adds Sentry proguard settings and adds a changelog for the initial release.

Testing Instructions

Ensure that exceptions from the release build are readable in Sentry.

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@ashiagr ashiagr requested a review from a team as a code owner June 12, 2023 15:04
mchowning
mchowning approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great! Thanks for this!

@mchowning mchowning enabled auto-merge June 12, 2023 15:32
@ashiagr ashiagr disabled auto-merge June 12, 2023 15:37
@ashiagr ashiagr enabled auto-merge June 12, 2023 15:44
@ashiagr ashiagr disabled auto-merge June 12, 2023 15:52
@ashiagr ashiagr merged commit af1f316 into main Jun 12, 2023
@ashiagr ashiagr deleted the task/sentry-proguard-setting branch June 12, 2023 16:20
@ashiagr ashiagr changed the title Add Sentry proguard setting for watch app Add Sentry proguard setting for watch app and add changelog Jun 13, 2023
@ashiagr ashiagr added this to the 7.42 milestone Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchowning mchowning mchowning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.42
Development

Successfully merging this pull request may close these issues.
2 participants
@ashiagr @mchowning