Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wear media notifications #1064

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Fix wear media notifications #1064

merged 1 commit into from
Jun 12, 2023

Conversation

mchowning
Copy link
Contributor

@mchowning mchowning commented Jun 9, 2023

Description

This fixes the watch app so that the system's media controls reflect our app's playback state. The fix for this is to not add custom media actions in the watch app. The reason we need to do this is because of a bug in Wear OS 3.5. This has been fixed by Google and will be released at some point in the future.

Fixes #1050

Thanks to @kul3r4, @yschimke, and the wear os team for their help figuring this out. 🙇

Testing Instructions

  1. Fesh install of the watch app on a physical device
  2. Begin playing an episode
  3. Go to the watch's home screen and wait a few seconds for the media notification to appear (it takes at least 5 seconds or so in my testing)
  4. Tap on the media notification
  5. Verify that you're taken back to our app
  6. Open the OS's "Media Controls" app
  7. Verify that the Media Controls reflect the episode our app is playing
  8. Verify that tapping pause stops playback. There is a fair bit of delay here for the UI to respond to the button tap. I also see quite a bit of delay in the Media Controls when the Youtube Music app is playing, so I don't think most of this delay is due to our app.
  9. Verify that tapping play resumes the podcast.

Screenshots or Screencast

Screenshot 2023-06-09 at 3 25 15 PM

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml

@mchowning mchowning added the [Area] Wear OS watch app label Jun 9, 2023
@mchowning mchowning added this to the 7.41 milestone Jun 9, 2023
@mchowning mchowning requested a review from a team as a code owner June 9, 2023 19:34
@ashiagr ashiagr merged commit f5d7334 into main Jun 12, 2023
@ashiagr ashiagr deleted the fix/wear-media-notification branch June 12, 2023 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wear media controls do not reflect playback state
2 participants