Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/incorporate network awareness library #1037

Closed
wants to merge 2 commits into from

Conversation

mchowning
Copy link
Contributor

Description

This expands the usage of the network awareness library to be used for (almost) all calls made from the watch app to improve the app's syncing performance. Before this PR we were only using network-awarenss for downloads.

Note
This PR does not include updates to our ExoPlayer usage, so streaming episodes is not using network-awareness. That's probably ok because using the default (and low-bandwidth) Bluetooth connection for streaming when it is available is better for the watch's battery, but I'll do some testing of this.

Testing Instructions

Test various flows in the app making sure that the logs show that an appropriate network is being used for each call (filtering your logs for "https request" can help here).

  • logging in
  • performing a refresh
  • download an episode
  • loading show notes by visiting an episode page

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews

@mchowning mchowning added the [Area] Wear OS watch app label Jun 2, 2023
@mchowning mchowning force-pushed the update/incorporate-network-awareness-library branch from d0eb533 to de9488c Compare June 3, 2023 01:37
@mchowning
Copy link
Contributor Author

Closing this since we don't have any immediate plans to make this switch.

@mchowning mchowning closed this Aug 17, 2023
@MiSikora MiSikora deleted the update/incorporate-network-awareness-library branch April 12, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant