Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Japanese show played setting #955

Merged
merged 2 commits into from
May 12, 2023
Merged

Conversation

geekygecko
Copy link
Member

@geekygecko geekygecko commented May 11, 2023

Description

The accepted translations for the show played setting in Android Automotive had been changed to English. This has been fixed. We normally add the translations as part of the release process but I wanted to know which version this was in and include it in the change log.

Testing Instructions

  1. Deploy the Automotive version
  2. Go to Settings
  3. Tap 'System'
  4. Tap 'Languages & input'
  5. Tap 'Languages'
  6. Change it to
Screenshot 2023-05-12 at 7 53 30 am
  1. Open Pocket Casts
  2. Tap settings and scroll down
  3. ✅ Verify there is no English

Screenshots

unnamed (4)

Before After
Screenshot_20230512_075358 Screenshot_20230512_080900

@geekygecko geekygecko marked this pull request as ready for review May 11, 2023 22:43
@geekygecko geekygecko requested a review from a team as a code owner May 11, 2023 22:43
Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@ashiagr ashiagr merged commit 3ee83ac into main May 12, 2023
@ashiagr ashiagr deleted the update/japanese-show-played branch May 12, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants