Upgrade to Premium freezes the app

[neeldoshii]

Description

Upgrade to Premium freezes the app this could be a high priority issues as this will affect people to convert to plus account, thus reducing plus members.

I have testing this over debug, debug prod build not yet tested over release.

Step-by-step reproduction instructions

1. Have a non plus account (free) account.
2. Go to Profile
3. Go to Settings
4. Go to Pocket Casts Plus
5. Click on any upgrade button

Screenshots or screen recording

Screen_recording_20231007_203937.mp4

Did you search for existing bug reports?

• I have searched for existing bug reports.

Device, Operating system, and Pocket Casts app version

Pixel 7

[CookieyedCodes]

From my understanding debug isn't connected to the servers so this is probably why 🤔

[neeldoshii]

Closing as the issue is irrelevant. Sorry for the inconvienience.

[CookieyedCodes]

@neeldoshii well I'd check or wait for a Dev to confirm but your call 😅

[mchowning]

The upgrade/purchase functionality isn't going to work on debug or debugProd builds because they can't communicate with Google about subscriptions, but the app shouldn't freeze like this even on debug builds, so this seems like a legitimate issue to me. Thanks for raising it @neeldoshii , I'll go ahead and reopen it.

I feel like this came up once before (and got fixed), but I can't seem to find the issue or PR now. 🤔

Might be good to just have clicking the button show a short toast indicating something like "Subscriptions are not available on debug builds".

[neeldoshii]

Well, I closed the issue first because I was too naive to not test in towards release but did check over debug, debug-prod build.

Well, it does makes sense that application should not freeze it completely on debug or debug-prod build.

Thanks for checking it Matt.

[neeldoshii]

@mchowning

Can we do one thing, make the button non clickable only on debug builds so this will avoid calling the google subscription function and thus wont freeze the app.

Dry run code

if debug build
    make button non clickable with toast (for new commers)
    
if release build
   call google subscription function

[neeldoshii]

also this issue is similar to #1158

[mchowning]

Your suggestion (#1443 (comment)) makes sense to me @neeldoshii . 👍

It might be worth checking other upgrade prompts in the app to make sure they're not also freezing because if they are we might want to find a place to handle this for all of them. For example, there are upgrade prompts on the bottom of the profile tab and on the podcasts tab's locked folder icon.

[mchowning]

Closing this because the upgrade "Pocket Casts Plus" screen in settings is not opened any more on debug builds if no subscriptions are available and, therefore, we can't get to the app-freezing state anymore. Instead, the app just displays a no subscriptions available message. I also verified that trying to upgrade from other parts of the app (upgrade banner on profile screen, folders, bookmarks also did not freeze the app). I also verified that release builds are still providing the appropriate upgrade prompts.

No subscription found screen