Skip to content

Commit

Permalink
Update Rubocop config to not allow Ruby 3.1 hash and arguments values…
Browse files Browse the repository at this point in the history
… omission
  • Loading branch information
iangmaia committed Oct 31, 2023
1 parent 805ce81 commit 11033ea
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 6 deletions.
3 changes: 3 additions & 0 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,6 @@ Metrics/MethodLength:
- scripts/themes/download_themes.rb
- scripts/themes/generate_themes.rb
- scripts/themes/generate_kotlin.rb

Style/HashSyntax:
EnforcedShorthandSyntax: never
12 changes: 6 additions & 6 deletions fastlane/Fastfile
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ platform :android do
extracted_notes_file_path: EXTRACTED_RELEASE_NOTES_PATH
)
android_update_release_notes(
new_version:,
new_version: new_version,
release_notes_file_path: RELEASE_NOTES_SOURCE_PATH
)
push_to_git_remote(tags: false)
Expand Down Expand Up @@ -294,7 +294,7 @@ platform :android do
release_assets = []

APPS.each do |app|
build_bundle(app:, version:, build_code:)
build_bundle(app: app, version: version, build_code: build_code)

aab_artifact_path = aab_artifact_path(app, version)
UI.error("Unable to find a build artifact at #{aab_artifact_path}") unless File.exist? aab_artifact_path
Expand All @@ -310,7 +310,7 @@ platform :android do
upload_to_play_store(
package_name: APP_PACKAGE_NAME,
aab: aab_artifact_path,
track:,
track: track,
release_status: 'draft',
skip_upload_apk: true,
skip_upload_metadata: true,
Expand All @@ -323,7 +323,7 @@ platform :android do
release_assets << aab_artifact_path
end

create_gh_release(version:, prerelease: is_beta, release_assets: release_assets.compact) if options[:create_gh_release]
create_gh_release(version: version, prerelease: is_beta, release_assets: release_assets.compact) if options[:create_gh_release]
end

lane :finalize_release do | options |
Expand Down Expand Up @@ -437,9 +437,9 @@ platform :android do

create_release(
repository: GH_REPOSITORY,
version:,
version: version,
release_notes_file_path: nil,
prerelease:,
prerelease: prerelease,
release_assets: release_assets.join(',')
)
end
Expand Down

0 comments on commit 11033ea

Please sign in to comment.