fix: remove translation workaround; the issue is fixed in WP #2415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurelfulford
added
the
[Status] Needs Review
dkoo
approved these changes
Nov 26, 2024
github-actions
bot
added
[Status] Approved
|
Thanks @dkoo! |
|
Hey @laurelfulford, good job getting this PR merged! 🎉 Now, the Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label. If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label. Thank you! ❤️ |
matticbot
pushed a commit
that referenced
this pull request
Nov 29, 2024
# [2.4.0-alpha.1](v2.3.0...v2.4.0-alpha.1) (2024-11-29) ### Bug Fixes * remove translation workaround; the issue is fixed in WP ([#2415](#2415)) ([da4efd9](da4efd9)) ### Features * add Bluesky to the profile fields ([#2413](#2413)) ([6651f67](6651f67)) * add Bluesky to the Social Links menu ([#2412](#2412)) ([16a33aa](16a33aa)) * merge RAS-ACC work into trunk ([#2417](#2417)) ([4488d59](4488d59))
|
🎉 This PR is included in version 2.4.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Dec 9, 2024
# [2.4.0](v2.3.0...v2.4.0) (2024-12-09) ### Bug Fixes * remove translation workaround; the issue is fixed in WP ([#2415](#2415)) ([da4efd9](da4efd9)) ### Features * add Bluesky to the profile fields ([#2413](#2413)) ([6651f67](6651f67)) * add Bluesky to the Social Links menu ([#2412](#2412)) ([16a33aa](16a33aa)) * merge RAS-ACC work into trunk ([#2417](#2417)) ([4488d59](4488d59))
|
🎉 This PR is included in version 2.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
In #2411, we tweaked how translations are loaded to work around a bug in WordPress 6.7. Now that that bug's been fixed in 6.7.1, we can rollback this change.
It looks like translations are still loaded in 6.7.1 with the fix in place, so I'm merging this into trunk instead of handling as a hotfix again.
How to test the changes in this Pull Request:
Other information: