fix: getting translations to load again #2411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurelfulford
added
the
[Status] Needs Review
chickenn00dle
approved these changes
Nov 19, 2024
github-actions
bot
added
[Status] Approved
matticbot
pushed a commit
that referenced
this pull request
Nov 19, 2024
## [2.2.1](v2.2.0...v2.2.1) (2024-11-19) ### Bug Fixes * getting translations to load again ([#2411](#2411)) ([110b039](110b039))
|
🎉 This PR is included in version 2.2.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Nov 19, 2024
# [2.3.0-alpha.2](v2.3.0-alpha.1...v2.3.0-alpha.2) (2024-11-19) ### Bug Fixes * getting translations to load again ([#2411](#2411)) ([110b039](110b039))
|
🎉 This PR is included in version 2.3.0-alpha.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Nov 20, 2024
# [2.3.0-epic-ras-acc.2](v2.3.0-epic-ras-acc.1...v2.3.0-epic-ras-acc.2) (2024-11-20) ### Bug Fixes * getting translations to load again ([#2411](#2411)) ([110b039](110b039))
|
🎉 This PR is included in version 2.3.0-epic-ras-acc.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Changes to how translations are handled in WordPress 6.7 seem to have caused issues with our theme loading translations. This PR is an attempt to fix it for the near term while we wait for the fix coming in WP 6.7.1.
See: https://core.trac.wordpress.org/ticket/62337
This PR also restores the theme's text domain that got changed here; the text domain is repeated in the PHP so this change didn't do anything, I just fixed it to rule it out.
See 1200550061930446-as-1208760301709694.
How to test the changes in this Pull Request:
Other information: