Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable popups on non-AMP pages with POST form elements #101

Merged
merged 1 commit into from
Apr 22, 2020

Conversation

adekbadek
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Because we load amp-form script on non-AMP pages to handle forms in AMP way, some other forms might be broken.
More context: ampproject/amphtml#27638

Closes #100

How to test the changes in this Pull Request:

  1. Create a page with a form that has method="POST"
  2. Create a popup that will appear on this page (e.g. sitewide overlay popup in test mode)
  3. Visit page with AMP disabled (disable plugin or set mode to Transitional)
  4. Observe that the popup does not show up
  5. Observe that the form can be submitted without errors

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Contributor

@jeffersonrabb jeffersonrabb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We'll come back to this when we know more about the AMP issue.

@adekbadek adekbadek force-pushed the fix/disable-if-form-found branch from b575ef9 to 961451b Compare April 9, 2020 07:43
@adekbadek adekbadek merged commit 366407d into master Apr 22, 2020
@adekbadek adekbadek deleted the fix/disable-if-form-found branch April 22, 2020 15:33
@adekbadek adekbadek mentioned this pull request Apr 22, 2020
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.3.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.2.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaks forms on non-AMP pages
3 participants