Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show "My Membership" links in My Account menu for team members #3542

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Nov 12, 2024

All Submissions:

Changes proposed in this Pull Request:

Allows the "My Membership" menu item and its submenu items to be shown to team members only. Team members who join a team by invitation have no other way to view or manage their team membership.

How to test the changes in this Pull Request:

  1. On this branch, create a team and assign an owner or manager
  2. Confirm that a regular reader (not a member or owner/manager of any team) and the team owner/manager do not see the "Memberships" or "My Membership" menu item in My Account.
  3. As the team owner/manager, invite another reader by email or link to join the team.
  4. In a new session, join the team via the invitation from step 3.
  5. Confirm that as the team member, you do see the "My Membership" menu item and its submenu items in My Account.
Screenshot 2024-11-12 at 10 41 31 AM

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo added the [Status] Needs Review The issue or pull request needs to be reviewed label Nov 12, 2024
@dkoo dkoo self-assigned this Nov 12, 2024
@dkoo dkoo requested a review from a team as a code owner November 12, 2024 17:41
@adekbadek adekbadek merged commit 634dd69 into fix/wc-teams-join-link Nov 13, 2024
9 checks passed
@adekbadek adekbadek deleted the fix/wc-teams-members-area-menu branch November 13, 2024 09:16
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants