Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (ras-acc): recaptcha badge side-scroll #3401

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR fixes an issue I've run into on the RAS-ACC testing site, but that I can't recreate locally 😕

When using reCAPTCHA 2, either after successfully passing the reCAPTCHA by picking bikes/crosswalks/traffic lights, or after getting an error, the registration modal has a side-scroll due to the recaptcha badge:

How to test the changes in this Pull Request:

  1. Set the site to use the invisible flavour of reCAPTCHA 2 under Newspack > Connections.
  2. In an incognito window, try signing in; hopefully you're like me and your behaviour is spammy enough to trigger something.
  3. After picking your bikes successfully and getting to the success screen, or getting an error on the initial screen, scroll the mouse to the right -- hopefully you get this:

CleanShot 2024-09-06 at 10 24 34

  1. Apply the PR and run npm run build.
  2. If you do get the side scroll, confirm that the PR fixes it; otherwise, please confirm that it doesn't cause any weirdness. The issue is the right style, but locally I only get three lines of inline CSS for this badge vs. ~12 for the RAS-ACC test site.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford added [Status] Needs Review The issue or pull request needs to be reviewed ras-acc testing labels Sep 6, 2024
@laurelfulford laurelfulford requested a review from a team as a code owner September 6, 2024 17:27
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Sep 9, 2024
@laurelfulford laurelfulford merged commit 12e1dab into epic/ras-acc Sep 9, 2024
8 checks passed
@laurelfulford laurelfulford deleted the fix/recaptcha-badge-scroll branch September 9, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ras-acc testing [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants