feat(ads): handle gam default ad units #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelpeixe
added
the
[Status] Needs Review
dkoo
approved these changes
May 27, 2022
github-actions
bot
added
[Status] Approved
matticbot
pushed a commit
that referenced
this pull request
Jun 2, 2022
# [1.84.0-alpha.1](v1.83.1...v1.84.0-alpha.1) (2022-06-02) ### Bug Fixes * **reader-revenue:** initial order state with total of 0 ([7c30b09](7c30b09)) ### Features * **ads:** handle gam default ad units ([#1654](#1654)) ([321b98e](321b98e)) * reader registration on donate ([#1655](#1655)) ([5821b57](5821b57)) * remove theme selection from setup wizard ([#1656](#1656)) ([94e4580](94e4580))
|
🎉 This PR is included in version 1.84.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
6 tasks
matticbot
pushed a commit
that referenced
this pull request
Jun 13, 2022
# [1.84.0](v1.83.3...v1.84.0) (2022-06-13) ### Bug Fixes * **ads:** resolve conflicts from hotfix merge ([#1685](#1685)) ([8ce12cd](8ce12cd)) * **reader-revenue:** initial order state with total of 0 ([7c30b09](7c30b09)) ### Features * **ads:** handle gam default ad units ([#1654](#1654)) ([321b98e](321b98e)) * **analytics:** automatically link GA4 with Site Kit ([#1698](#1698)) ([266135f](266135f)) * reader registration on donate ([#1655](#1655)) ([5821b57](5821b57)) * remove theme selection from setup wizard ([#1656](#1656)) ([94e4580](94e4580))
|
🎉 This PR is included in version 1.84.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Wizard changes to properly handle the default ad units implementation from Automattic/newspack-ads#406
How to test the changes in this Pull Request:
Testing instructions at Automattic/newspack-ads#406
Other information: