fix(my-account): fixes for My Account

[dkoo]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Fixes a few bugs affecting My Account. Replaces #2899. See also Automattic/newspack-blocks#1661 and Automattic/newspack-theme#2240

How to test the changes in this Pull Request:

Required billing fields for gift recipients

When the recipient of a gifted subscription logs into My Account for the first time, WooCommerce asks them to fill in some required billing information. This info should match the selected fields in Reader Revenue settings.

1. install the Gift Subscriptions extension if you don't already have it.
2. As a reader, purchase a subscription as a gift for another email address.
3. On release, in a new session, log in as the gift recipient. Observe that you're asked for shipping address details in a strangely styled form:

4. Check out this branch (and fix(my-account): fixes for My Account #2904 and fix(my-account): fixes for My Account newspack-theme#2240) and the corresponding branch in the Theme and refresh. Confirm that the form now only asks for First Name and Last Name fields, if they're required in Reader Revenue settings.

Gift recipients can't see "Subscriptions" menu item in My Account

1. After completing the form in the previous instructions, on release, observe that there's no Subscriptions menu item in the My Account navigation sidebar.
2. Check out this branch (and fix(my-account): fixes for My Account #2904 and fix(my-account): fixes for My Account newspack-theme#2240), refresh, and confirm the Subscriptions menu item now shows up and that clicking it shows the subscription you were gifted.

Can't renew subscriptions from the Subscription page

1. As a reader, complete a subscription donation and then log into My Account/verify as needed.
2. On release, go to My Subscription and click "Renew Now". Observe that you get redirected with no feedback, and the renewal request is never processed.
3. Check out this branch (and fix(my-account): fixes for My Account #2904 and fix(my-account): fixes for My Account newspack-theme#2240 and repeat. Now confirm that you clicking "Renew Now" brings you to a checkout form which you can complete to renew early.

Thank you page for renewals shows modal checkout thank you template despite not being modal checkout

#1573 added some additional hook callbacks to force modal checkout styles in the thank you page for express checkout methods (Google/Apple Pay), but #1654 implements a similar fix with a more reliable check for whether the express checkout request originated in a modal checkout flow, so these hooks are no longer needed.

1. Check out this branch (and fix(my-account): fixes for My Account #2904 and fix(my-account): fixes for My Account newspack-theme#2240) and repeat the renewal process as described above.
2. After completing the renewal, confirm that the thank you page shown is the standard WooCommerce thank you template, and not our minimalist modal version.

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

[dkoo]

Note: Rebased against epic/ras-acc as gift subscription functionality has been fixed in the epic, not in trunk.

[chickenn00dle]

Hey @dkoo,

I tried testing this but ran into a few issues, with the modal checkout. Not sure if some other changes to epic/ras-acc might be conflicting with those in the three PRs that make up these fixes, but am seeing:

1. A fatal related to a missing method in blocks: fix(my-account): fixes for My Account newspack-blocks#1661 (comment)
2. And some wonky behavior in the modal checkout preventing me from actually purchasing a gift sub:

Screen.Recording.2024-02-06.at.11.26.48.mov

[dkoo]

@chickenn00dle looks like the branch needed a merge from the epic. Checkout and gifting should be working again

[chickenn00dle]

Nice! Thanks for clearing that up. This is working as expected now 👍

[matticbot]

🎉 This PR is included in version 3.0.0-epic-ras-acc.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[matticbot]

🎉 This PR is included in version 3.1.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[matticbot]

🎉 This PR is included in version 3.2.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[matticbot]

🎉 This PR is included in version 3.6.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[matticbot]

🎉 This PR is included in version 3.9.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[matticbot]

🎉 This PR is included in version 4.1.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[matticbot]

🎉 This PR is included in version 4.2.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[matticbot]

🎉 This PR is included in version 4.4.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀