Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(woocommerce): hook for rendering UTM inputs #2671

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

miguelpeixe
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

The feature implemented in #2665 might not work as expected if the reader is prompted to go through the 2-step checkout (new readers).

This PR ensures the UTM inputs are rendered in a hook that is not conditioned to any checkout step, fixing the issue.

How to test the changes in this Pull Request:

  1. While on the master branch, visit a page with the Donate block and the ?utm_campaign=test query param anonymously
  2. Confirm the order is placed without the UTM param
  3. Check out this branch, repeat the anonymous purchase and confirm the UTM param is stored

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@miguelpeixe miguelpeixe added the [Status] Needs Review The issue or pull request needs to be reviewed label Sep 28, 2023
@miguelpeixe miguelpeixe requested a review from a team as a code owner September 28, 2023 14:12
@miguelpeixe miguelpeixe self-assigned this Sep 28, 2023
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Sep 28, 2023
@miguelpeixe miguelpeixe merged commit 634f7bf into master Sep 28, 2023
2 checks passed
@miguelpeixe miguelpeixe deleted the fix/wc-order-utm-input-hook branch September 28, 2023 14:26
matticbot pushed a commit that referenced this pull request Sep 28, 2023
# [2.8.0-alpha.1](v2.7.1...v2.8.0-alpha.1) (2023-09-28)

### Bug Fixes

* **woocommerce:** hook for rendering UTM inputs ([#2671](#2671)) ([634f7bf](634f7bf))

### Features

* add RAS CLI commands ([#2666](#2666)) ([5afc049](5afc049))
* remove unused GA code ([#2664](#2664)) ([1fa99fa](1fa99fa))
* search credit metadata on media library ([#2594](#2594)) ([c33c5b2](c33c5b2))
* **woocommerce:** store UTM parameters as order meta ([#2665](#2665)) ([39dfc31](39dfc31))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.8.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Oct 9, 2023
# [2.8.0](v2.7.5...v2.8.0) (2023-10-09)

### Bug Fixes

* inline documentation for `Donations::get_donation_settings()` ([#2675](#2675)) ([c6c7916](c6c7916))
* **woocommerce:** check method exists before syncing reader ([#2673](#2673)) ([063509c](063509c))
* **woocommerce:** hook for rendering UTM inputs ([#2671](#2671)) ([634f7bf](634f7bf))

### Features

* add RAS CLI commands ([#2666](#2666)) ([5afc049](5afc049))
* **campaigns:** newsletter subscription list criteria ([#2658](#2658)) ([69c8f88](69c8f88))
* remove unused GA code ([#2664](#2664)) ([1fa99fa](1fa99fa))
* search credit metadata on media library ([#2594](#2594)) ([c33c5b2](c33c5b2))
* **woocommerce:** store UTM parameters as order meta ([#2665](#2665)) ([39dfc31](39dfc31))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants