Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: search credit metadata on media library #2594

Merged
merged 2 commits into from
Sep 20, 2023
Merged

feat: search credit metadata on media library #2594

merged 2 commits into from
Sep 20, 2023

Conversation

leogermani
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Also look in the credits metadata when searching for media in the Media library.

How to test the changes in this Pull Request:

  1. Go to Media > Library
  2. Edit a couple of media items and add some information to the credits fields (Make sure those strings don't exist in the post title or content)
  3. Perform a search typing part of the strings that you added to the credits fields
  4. confirm that the media with those credits are returned
  5. perform another search with a string present in the title of other media and confirm it still works as usual
  6. perform other combination of searches and confirm they all work (a string only in the meta, a string only in post tittle, a string in both places, etc)

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@leogermani leogermani added the [Status] Needs Review The issue or pull request needs to be reviewed label Aug 11, 2023
@leogermani leogermani self-assigned this Aug 11, 2023
@leogermani leogermani requested a review from a team as a code owner August 11, 2023 17:58
@dkoo dkoo merged commit c33c5b2 into master Sep 20, 2023
1 check passed
@dkoo dkoo deleted the feat/search-media-metadata branch September 20, 2023 22:25
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Sep 20, 2023
matticbot pushed a commit that referenced this pull request Sep 28, 2023
@semantic-release-bot
chore(release): 2.8.0-alpha.1 [skip ci]
62e0013 
# [2.8.0-alpha.1](v2.7.1...v2.8.0-alpha.1) (2023-09-28)

### Bug Fixes

* **woocommerce:** hook for rendering UTM inputs ([#2671](#2671)) ([634f7bf](634f7bf))

### Features

* add RAS CLI commands ([#2666](#2666)) ([5afc049](5afc049))
* remove unused GA code ([#2664](#2664)) ([1fa99fa](1fa99fa))
* search credit metadata on media library ([#2594](#2594)) ([c33c5b2](c33c5b2))
* **woocommerce:** store UTM parameters as order meta ([#2665](#2665)) ([39dfc31](39dfc31))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.8.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Oct 9, 2023
@semantic-release-bot
chore(release): 2.8.0 [skip ci]
1fb417c 
# [2.8.0](v2.7.5...v2.8.0) (2023-10-09)

### Bug Fixes

* inline documentation for `Donations::get_donation_settings()` ([#2675](#2675)) ([c6c7916](c6c7916))
* **woocommerce:** check method exists before syncing reader ([#2673](#2673)) ([063509c](063509c))
* **woocommerce:** hook for rendering UTM inputs ([#2671](#2671)) ([634f7bf](634f7bf))

### Features

* add RAS CLI commands ([#2666](#2666)) ([5afc049](5afc049))
* **campaigns:** newsletter subscription list criteria ([#2658](#2658)) ([69c8f88](69c8f88))
* remove unused GA code ([#2664](#2664)) ([1fa99fa](1fa99fa))
* search credit metadata on media library ([#2594](#2594)) ([c33c5b2](c33c5b2))
* **woocommerce:** store UTM parameters as order meta ([#2665](#2665)) ([39dfc31](39dfc31))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

dkoo added a commit that referenced this pull request Oct 10, 2023
@dkoo
fix: temporarily disable query filtering from #2594
1f53116
@dkoo dkoo mentioned this pull request Oct 10, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkoo dkoo dkoo approved these changes

Assignees

@leogermani leogermani

Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leogermani @matticbot @dkoo