fix: media credit placeholder

Automattic · Sep 19, 2024 · 2f1afdb · 2f1afdb
1 parent cab80c9
commit 2f1afdb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/includes/class-newspack-image-credits.php b/includes/class-newspack-image-credits.php
@@ -403,7 +403,7 @@ public static function get_default_settings( $key = null ) {
 				'key'         => 'newspack_image_credits_placeholder',
 				'label'       => __( 'Placeholder Image', 'newspack-image-credits' ),
 				'type'        => 'image',
-				'value'       => null,
+				'value'       => '',
 			],
 			[
 				'description' => __( 'Automatically populate image credits from EXIF or IPTC metadata when uploading new images.', 'newspack-image-credits' ),

diff --git a/includes/wizards/class-setup-wizard.php b/includes/wizards/class-setup-wizard.php
@@ -520,7 +520,7 @@ public function api_update_theme_with_mods( $request ) {
 				continue;
 			}
 
-			if ( null !== $value && in_array( $key, $this->media_theme_mods ) ) {
+			if ( '' !== $value && in_array( $key, $this->media_theme_mods ) ) {
 				$value = $value['id'];
 			}
 			set_theme_mod( $key, $value );