Add tags support to Constant Contact

[leogermani]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Adds support to Tags for the Constant Contact provider. This will enable the new Lists feature for this provider.

How to test the changes in this Pull Request:

1. Set Constant Contact as the provider with proper credentials
2. Go to Newsletter > Lists
3. Create a new list
4. Confirm that a correspondent tag is created in the provider
5. Go to Newsletter > Settings and enable the list in the Subsctiption Lists section
6. Add a registration or Newsletter subscription block to your site with that list as an option
7. As a visitor, register to a newsletter selecting that list
8. confirm the contact is created with the correct tag in the provider
9. confirm also that a Segment was created with users tagged with this tag
10. (Note: Constant Contact is not supported in the "My account" page for managing subscriptions, this is unrelated with this PR)
11. As a failsafe, make sure the same steps above are still working with other providers

Also note that the ability to select this segment in the editor when sending newsletters will be added in another PR (UPDATE: It was added in #1055)

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

[dkoo]

Works well as described. I have some questions that may or may not be relevant.

[leogermani]

We are holding this until we get a resolution whether we are shipping this feature or not. See pamTN9-5Em-p2#comment-7332

[dkoo]

Thanks for the comments and update, @leogermani—I was about to approve this one but will hold off until we ship the feature again.

[leogermani]

We can get a new review on this one now @dkoo , thanks!

[dkoo]

This is still working as described, but something I noticed that seems true of all ESPs: updates to the local list names in WP don't persist to the corresponding ESP tag/group. Is this known/intentional? To test:

1. Create a local list, observe that it's created in the ESP
2. Update the name of the local list in WP, observe that the name no longer matches in the ESP
3. Subscribing to the local list as a reader still subscribes to the correct tag/group in the ESP, so it's more of a semantic/UX issue for publishers than a technical issue.

Another nitpick: when editing a single local list, the Newsletter > Lists menu item isn't expanded (although "Lists" is highlighted when you hover over "Newsletters").

[leogermani]

This is still working as described, but something I noticed that seems true of all ESPs: updates to the local list names in WP don't persist to the corresponding ESP tag/group. Is this known/intentional?

At some point this was intentional, but we discussed that we should change this behavior. There's a task for that already:
1200550061930446-as-1203598613652135

Another nitpick: when editing a single local list, the Newsletter > Lists menu item isn't expanded (although "Lists" is highlighted when you hover over "Newsletters").

Yeah I noticed that. I'll try to see if there's a workaround for it.

[leogermani]

Fixed the menu behavior in #1092

[dkoo]

Thanks for the explanation! Since we're handling those two issues in other tasks/PRs, this one looks good 👍

[matticbot]

🎉 This PR is included in version 1.60.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[matticbot]

🎉 This PR is included in version 1.60.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀