Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(marketplace): email settings #718

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

miguelpeixe
Copy link
Member

@miguelpeixe miguelpeixe commented Sep 4, 2023

Implements support for custom email notifications on marketplace orders.

image

How to test this PR

  1. Check out this branch and feat(ads): marketplace settings wizard newspack-plugin#2628
  2. Make sure you are connected to a GAM account and have marketplace products created (see feat(marketplace): product creation #566)
  3. Visit Advertising -> Marketplace -> Settings
  4. Confirm it renders as in the image above
  5. Set a custom email and save
  6. Make sure you have "New Order" emails enabled in WC (per form instruction)
  7. Edit a new page and add the "Marketplace" block, which renders only a placeholder component in the editor
  8. Visit the page, select a product, a valid date range (cannot be starting Today), and upload creatives that match the ad product requirements of size (see feat(marketplace): support creative upload #670)
  9. Proceed to payment and place the order
  10. Confirm the email is sent with the following subject line: [Site Name] New Marketplace Ad Order #{order_id}
  11. Confirm the email body has a link to "View order in GAM"

@miguelpeixe miguelpeixe self-assigned this Sep 5, 2023
@miguelpeixe miguelpeixe marked this pull request as ready for review September 5, 2023 19:24
@miguelpeixe miguelpeixe requested a review from a team as a code owner September 5, 2023 19:24
Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as described!

@miguelpeixe miguelpeixe merged commit 8816764 into epic/marketplace Sep 20, 2023
2 checks passed
@miguelpeixe miguelpeixe deleted the feat/marketplace-settings branch September 20, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants