Kill full sitemap cron generation #99
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This keeps the ongoing cron-based updates (triggered every 15 minutes) although can be replaced with your own system, see https://github.com/Automattic/msm-sitemap/blob/master/wpcom-helper.php#L3 |
|
Wouldn't this change result in lots of queued crons, but no action to execute them?
|
mjangda
force-pushed
the
kill/full-site-cron
branch
from
9b48380
to
25ffc54
Compare
For really large datasets, this ends up in a flood of thousands of cron events that can slow down or completely disable a site. Fixes #81
We no longer need to disable the cron and add a workaround since the initial cron stuff no longer exists.
We need something to actually trigger the scheduled cron events
mjangda
force-pushed
the
kill/full-site-cron
branch
from
25ffc54
to
dc38121
Compare
Yep, great catch. I've restored the relevant code. A few other things we probably need to do:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For really large datasets, this ends up in a flood of thousands of cron events that can
slow down or completely disable a site.
Fixes #81