Substitute cal_days_in_month #130
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds cal_days_in_month method to Metro_Sitemap_CLI class which either calls PHP Calendar's cal_days_in_month function, or does calculation using `date('t')` and `mktime`` functions.
Currently only covers the newly added cal_days_in_month method. This commit also includes a mocks for WP_CLI and WP_CLI_Command classes. We'll have to replace those once we increase the test coverage of the Metro_Sitemap_CLI class.
Adds setup and teardown methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
Metro_Sitemap_CLI::cal_days_in_monthmethod, which either usescal_days_in_monthfunction if PHP Calendar extension is installed or calculates the max number of days in month using thedate( 't' )andmktimefunctions.It also adds first unit tests for the
Metro_Sitemap_CLIclass, currently only covering the newcal_days_in_month. TheWP_CLIandWP_CLI_Commandclasses are currently only mocked, as they are really not needed for existing tests.