Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #8371 #8428

Merged
Merged

Conversation

AbdelrahmanHafez
Copy link
Collaborator

Add test for #8371 verifying that setting document.isNew = true; makes document.save() tries to insert a new document.

@AbdelrahmanHafez AbdelrahmanHafez changed the title Add test for #8371 (setting isNew to true inserts) Fixes #8371 Dec 14, 2019
@AbdelrahmanHafez
Copy link
Collaborator Author

I keep getting random timeouts, gonna close and re-open the PR to trigger a new build.

@vkarpov15 vkarpov15 added this to the 5.8.2 milestone Dec 20, 2019
@vkarpov15 vkarpov15 merged commit a8a7497 into Automattic:master Dec 20, 2019
@AbdelrahmanHafez AbdelrahmanHafez deleted the feat/check-existence-on-save branch March 20, 2020 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants