types(connection): make transaction() return type match the executor function #14661

vkarpov15 · 2024-06-10T21:19:41Z

Summary

In MongoDB driver 6.x, withTransaction() now returns the executor function's return value. Mongoose should match that change.

Examples

Fix problem when deleting an entry on a populated Map

…function Fix #14656

test/types/connection.test.ts

Co-authored-by: hasezoey <[email protected]>

futurliberta and others added 4 commits June 8, 2024 14:32

Fix problem when deleting an entry on a populated Map

5e4023f

remove unnecessary comment

26ab76a

Merge pull request #14654 from futurliberta/fix-populated-map

7bc5395

Fix problem when deleting an entry on a populated Map

types(connection): make transaction() return type match the executor …

7bfd2bc

…function Fix #14656

vkarpov15 added this to the 8.5 milestone Jun 10, 2024

vkarpov15 requested review from hasezoey and AbdelrahmanHafez June 10, 2024 21:19

hasezoey approved these changes Jun 11, 2024

View reviewed changes

test/types/connection.test.ts Outdated Show resolved Hide resolved

Update test/types/connection.test.ts

90a2b5d

Co-authored-by: hasezoey <[email protected]>

vkarpov15 changed the base branch from master to 8.5 June 11, 2024 21:48

vkarpov15 merged commit 90fa8af into 8.5 Jun 11, 2024
27 checks passed

hasezoey deleted the vkarpov15/gh-14656 branch June 12, 2024 05:07

akanchhaS mentioned this pull request Jul 30, 2024

[Snyk] Upgrade mongoose from 4.2.4 to 8.5.0 akanchhaS/github-goof-npm#1292

Open

Erenkrs mentioned this pull request Jul 30, 2024

[Snyk] Upgrade mongoose from 8.1.3 to 8.5.0 Erenkrs/Uptime-Site#506

Open

NotZarifGithub mentioned this pull request Jul 30, 2024

[Snyk] Upgrade mongoose from 8.0.2 to 8.5.0 NotZarifGithub/InspiroVerse---ReactPractice-MERN-#112

Open

issam-seghir mentioned this pull request Jul 30, 2024

[Snyk] Upgrade mongoose from 8.0.3 to 8.5.0 issam-seghir/VipeTrip#35

Open

Gabo-Tech mentioned this pull request Jul 30, 2024

[Snyk] Upgrade mongoose from 5.13.14 to 8.5.0 Gabo-Tech/toDoList#297

Open

k2xl mentioned this pull request Jul 30, 2024

[Snyk] Upgrade mongoose from 8.4.0 to 8.5.0 sspenst/thinky.gg#1131

Closed

carltrepanier mentioned this pull request Jul 30, 2024

[Snyk] Upgrade mongoose from 8.4.5 to 8.5.0 carltrepanier/threads_clone#195

Merged

ilovepixelart mentioned this pull request Jul 30, 2024

[Snyk] Upgrade mongoose from 8.4.5 to 8.5.0 ilovepixelart/ts-migrate-mongoose#316

Closed

MihikaNigam mentioned this pull request Jul 30, 2024

[Snyk] Upgrade mongoose from 8.1.1 to 8.5.0 MihikaNigam/Secure-Full-Stack-Web-App-with-Login#102

Open

This was referenced Jul 30, 2024

[Snyk] Upgrade mongoose from 8.4.5 to 8.5.0 ilovepixelart/ts-cache-mongoose#218

Closed

[Snyk] Upgrade mongoose from 8.4.5 to 8.5.0 ilovepixelart/ts-patch-mongoose#228

Closed

This was referenced Jul 30, 2024

[Snyk] Upgrade mongoose from 8.0.0 to 8.5.0 axqqt/TorrentingLol#26

Open

[Snyk] Upgrade mongoose from 8.0.0 to 8.5.0 axqqt/SpotifySocialApp#26

Open

[Snyk] Upgrade mongoose from 8.0.0 to 8.5.0 axqqt/SDGP#29

Open

vky5 mentioned this pull request Jul 30, 2024

[Snyk] Upgrade mongoose from 8.3.4 to 8.5.0 vky5/onspot#3

Closed

clifford-snyk-github mentioned this pull request Jul 31, 2024

[Snyk] Upgrade mongoose from 4.2.4 to 8.5.0 Clifford-GitHub-Organization/nodejs-goof#31

Closed

bakiUru mentioned this pull request Jul 31, 2024

[Snyk] Upgrade mongoose from 8.4.4 to 8.5.0 bakiUru/BarberApi#2

Open

WontonSam mentioned this pull request Jul 31, 2024

[Snyk] Upgrade mongoose from 5.13.2 to 8.5.0 WontonSam/CSV-to-MongoDB#22

Open

This was referenced Sep 1, 2024

[Snyk] Upgrade mongoose from 8.1.3 to 8.5.2 Erenkrs/Uptime-Site#641

Open

[Snyk] Upgrade mongoose from 8.1.3 to 8.5.2 Erenkrs/Uptime-Site#646

Open

nejidevelops mentioned this pull request Sep 2, 2024

[Snyk] Upgrade mongoose from 8.1.2 to 8.5.2 nejidevelops/expense-tracker#26

Open

akanchhaS mentioned this pull request Sep 3, 2024

[Snyk] Upgrade mongoose from 4.2.4 to 8.5.2 akanchhaS/github-goof-npm#1308

Open

Gabo-Tech mentioned this pull request Sep 3, 2024

[Snyk] Upgrade mongoose from 5.13.14 to 8.5.2 Gabo-Tech/toDoList#300

Open

issam-seghir mentioned this pull request Sep 3, 2024

[Snyk] Upgrade mongoose from 8.0.3 to 8.5.2 issam-seghir/VipeTrip#59

Open

aviraj1703 mentioned this pull request Sep 3, 2024

[Snyk] Upgrade mongoose from 8.1.0 to 8.5.2 aviraj1703/place-explorer#38

Open

Erenkrs mentioned this pull request Sep 3, 2024

[Snyk] Upgrade mongoose from 8.1.3 to 8.5.2 Erenkrs/Uptime-Site#651

Open

MihikaNigam mentioned this pull request Sep 3, 2024

[Snyk] Upgrade mongoose from 8.1.1 to 8.5.2 MihikaNigam/Secure-Full-Stack-Web-App-with-Login#117

Open

This was referenced Sep 3, 2024

[Snyk] Upgrade mongoose from 8.0.0 to 8.5.2 axqqt/SpotifySocialApp#29

Open

[Snyk] Upgrade mongoose from 8.0.0 to 8.5.2 axqqt/SDGP#39

Open

[Snyk] Upgrade mongoose from 8.0.0 to 8.5.2 axqqt/TorrentingLol#29

Open

ibrahim-mohamed-zaghloul mentioned this pull request Sep 3, 2024

[Snyk] Upgrade mongoose from 8.2.0 to 8.5.2 ibrahim-mohamed-zaghloul/Three-tier-app-k8s#6

Open

issam-seghir mentioned this pull request Sep 4, 2024

[Snyk] Upgrade mongoose from 8.0.3 to 8.5.3 issam-seghir/VipeTrip#60

Open

akanchhaS mentioned this pull request Sep 4, 2024

[Snyk] Upgrade mongoose from 4.2.4 to 8.5.3 akanchhaS/github-goof-npm#1310

Open

Gabo-Tech mentioned this pull request Sep 4, 2024

[Snyk] Upgrade mongoose from 5.13.14 to 8.5.3 Gabo-Tech/toDoList#301

Open

aviraj1703 mentioned this pull request Sep 4, 2024

[Snyk] Upgrade mongoose from 8.1.0 to 8.5.3 aviraj1703/place-explorer#39

Open

lholmquist mentioned this pull request Sep 4, 2024

[Snyk] Upgrade mongoose from 6.12.0 to 8.5.3 nodeshift/mern-workshop#239

Closed

NotZarifGithub mentioned this pull request Sep 4, 2024

[Snyk] Upgrade mongoose from 8.0.2 to 8.5.3 NotZarifGithub/InspiroVerse---ReactPractice-MERN-#121

Open

Erenkrs mentioned this pull request Sep 4, 2024

[Snyk] Upgrade mongoose from 8.1.3 to 8.5.3 Erenkrs/Uptime-Site#656

Open

ibrahim-mohamed-zaghloul mentioned this pull request Sep 4, 2024

[Snyk] Upgrade mongoose from 8.2.0 to 8.5.3 ibrahim-mohamed-zaghloul/Three-tier-app-k8s#7

Open

This was referenced Sep 4, 2024

[Snyk] Upgrade mongoose from 8.0.0 to 8.5.3 axqqt/TorrentingLol#31

Open

[Snyk] Upgrade mongoose from 8.0.0 to 8.5.3 axqqt/SpotifySocialApp#31

Open

[Snyk] Upgrade mongoose from 8.0.0 to 8.5.3 axqqt/SDGP#41

Open

MihikaNigam mentioned this pull request Sep 4, 2024

[Snyk] Upgrade mongoose from 8.1.1 to 8.5.3 MihikaNigam/Secure-Full-Stack-Web-App-with-Login#118

Open

nejidevelops mentioned this pull request Sep 4, 2024

[Snyk] Upgrade mongoose from 8.1.2 to 8.5.3 nejidevelops/expense-tracker#27

Open

Gabo-Tech mentioned this pull request Sep 6, 2024

[Snyk] Upgrade mongoose from 5.13.14 to 8.5.3 Gabo-Tech/toDoList#302

Open

GoGPenguin mentioned this pull request Sep 6, 2024

[Snyk] Upgrade mongoose from 8.4.1 to 8.5.3 GoGPenguin/Music-App-API#1

Open

Erenkrs mentioned this pull request Sep 6, 2024

[Snyk] Upgrade mongoose from 8.1.3 to 8.5.3 Erenkrs/Uptime-Site#661

Open

nejidevelops mentioned this pull request Sep 6, 2024

[Snyk] Upgrade: dotenv, express, mongoose nejidevelops/expense-tracker#28

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

types(connection): make transaction() return type match the executor function #14661

types(connection): make transaction() return type match the executor function #14661

vkarpov15 commented Jun 10, 2024

types(connection): make transaction() return type match the executor function #14661

types(connection): make transaction() return type match the executor function #14661

Conversation

vkarpov15 commented Jun 10, 2024