Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query+populate): add refPath to projection by default, unless explicitly excluded #13758

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

vkarpov15
Copy link
Collaborator

Fix mongodb-js/mongoose-autopopulate#96

Summary

In order to populate() correctly, we need the field referenced by refPath. We already project in populated fields by default, so adding refPath unless explicitly excluded is reasonable.

Examples

@vkarpov15 vkarpov15 added this to the 7.4.4 milestone Aug 22, 2023
@vkarpov15 vkarpov15 merged commit b0258e1 into master Aug 22, 2023
34 checks passed
@vkarpov15 vkarpov15 deleted the vkarpov15/mongoose-autopopulate-96 branch August 22, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesn't autopopulate with refPath when documents are autopopulated from a virtual field
2 participants