feat: add skipMiddlewareFunction()
and overwriteMiddlewareResult()
for skipping and modifying middleware results
#11927
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11426
Fix #8393
Summary
Right now there's no way to overwrite the result of a function in a
post()
hook. For example, there's no way to usefilter()
to modify afind()
result in apost('find')
hook.There's also no way to "cancel" an operation in a pre hook without throwing an error. Which is inconvenient, because there are some use cases where it would be great to skip executing the underlying function (local caching, memorizing results, etc.)
This PR adds
overwriteMiddlewareResult()
for the former, andskipMiddlewareFunction()
for the latter, from mongoosejs/kareem#30 .@AbdelrahmanHafez @Uzlopak what do you think about the naming and overall idea?
Examples
See tests