Merge pull request #14752 from adf0nt3s/bsager/fix-incorrect-shardkey…

…-set Correct shardkey access in buildBulkWriteOps
Automattic · Jul 19, 2024 · e4462c6 · e4462c6
2 parents 1b88765 + 693398f
commit e4462c6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/model.js b/lib/model.js
@@ -3631,7 +3631,7 @@ Model.buildBulkWriteOperations = function buildBulkWriteOperations(documents, op
         const len = paths.length;
 
         for (let i = 0; i < len; ++i) {
-          where[paths[i]] = shardKey[paths[i]];
+          where[paths[i]] = document[paths[i]];
         }
       }
 

diff --git a/test/model.test.js b/test/model.test.js
@@ -6365,9 +6365,9 @@ describe('Model', function() {
   describe('buildBulkWriteOperations() (gh-9673)', () => {
     it('builds write operations', async() => {
 
-
       const userSchema = new Schema({
-        name: { type: String }
+        name: { type: String },
+        a: { type: Number }
       }, { shardKey: { a: 1 } });
 
       const User = db.model('User', userSchema);
@@ -6386,7 +6386,7 @@ describe('Model', function() {
       const desiredWriteOperations = [
         { insertOne: { document: users[0] } },
         { insertOne: { document: users[1] } },
-        { updateOne: { filter: { _id: users[2]._id, a: 1 }, update: { $set: { name: 'I am the updated third name' } } } }
+        { updateOne: { filter: { _id: users[2]._id, a: 3 }, update: { $set: { name: 'I am the updated third name' } } } }
       ];
 
       assert.deepEqual(