Site Editor: do not display Jetpack sidebar panels when not needed

[jeherve]

Proposed changes:

Following recent changes in the Gutenberg plugin, we currently display some Jetpack sidebar panels in the site editor, when they do not make sense because they would only apply to specific posts or pages:

• The QR code panel
• The Social Previews panel
• The SEO Tools panel
• The AI Assistant panel.

While Gutenberg will address that issue in WordPress/gutenberg#62531, it would be nice for us to add a safeguard, as recommended here:
https://make.wordpress.org/core/2024/06/18/editor-unified-extensibility-apis-in-6-6/

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

• Epic: WordPress 6.6 compatibility #36721
• Related issue: WP 6.6: move from Post Editor to Site Editor versions of Utilities #37713

Does this pull request change what data or activity we track or use?

• No

Testing instructions:

You can test this on a site running the Gutenberg plugin version 18.5.

• Go to Appearance > Editor
• Check if there are any Jetpack sidebar elements.
  • You should see none with this PR applied.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/editor-api-66 branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack update/editor-api-66
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen daily.
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for July 2, 2024 (scheduled code freeze on July 1, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[renatoagds]

We're using AI Assistant panel in other places (Document Settings, Pre-Publish) than Jetpack Sidebar, we should trigger an early return and remove it from all places?

[jeherve]

Pre-Publish shouldn't be a concern here since it's not displayed in the site editor. I'm thinking Document Settings may still be valuable (and work) in the site editor though; what do you think?

[renatoagds]

@jeherve Thinking better about, don't think any of the current features we have on AI suits good with Site Editor. I think we're good on the early return. If we change the mind in the future we can return and update cc/ @Automattic/jetpack-agora

[jeherve]

Does this mean we should add early returns elsewhere in addition to what I've added here?

[renatoagds]

@jeherve don't think so, this is the entry for all features that lives on the sidebar.

[dhasilva]

Yeah, current features do not suit the Site Editor. Breve could be an exception later on, but that is for the future us.

[monsieur-z]

The PR tests as advertised and the code changes look good.

It may be worth creating a dedicated hook to avoid duplication if the code is here to stay.

[jeherve]

It may be worth creating a dedicated hook to avoid duplication if the code is here to stay.

That's a good point. I suspect we may not need that code in the long run, since the post editor and site editor will be more separated in the future, but I'll keep it in mind.