Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wordpress monorepo #37669

Merged
merged 9 commits into from
Jun 4, 2024
Merged

Update wordpress monorepo #37669

merged 9 commits into from
Jun 4, 2024

Conversation

matticbot
Copy link
Contributor

@matticbot matticbot commented Jun 1, 2024

This PR contains the following updates:

Package Type Update Change
@wordpress/annotations (source) dependencies major 2.57.0 -> 3.0.0
@wordpress/api-fetch (source) dependencies major 6.54.0 -> 7.0.0
@wordpress/api-fetch (source) devDependencies major 6.54.0 -> 7.0.0
@wordpress/babel-plugin-import-jsx-pragma (source) devDependencies major 4.40.0 -> 5.0.0
@wordpress/babel-preset-default (source) devDependencies major 7.41.0 -> 8.0.0
@wordpress/base-styles (source) dependencies major 4.48.0 -> 5.0.0
@wordpress/base-styles (source) devDependencies major 4.48.0 -> 5.0.0
@wordpress/blob (source) devDependencies major 3.57.0 -> 4.0.0
@wordpress/blob (source) dependencies major 3.57.0 -> 4.0.0
@wordpress/block-editor (source) dependencies major 12.25.0 -> 13.0.0
@wordpress/block-editor (source) devDependencies major 12.25.0 -> 13.0.0
@wordpress/block-library (source) devDependencies major 8.34.0 -> 9.0.0
@wordpress/block-serialization-default-parser (source) devDependencies major 4.57.0 -> 5.0.0
@wordpress/blocks (source) dependencies major 12.34.0 -> 13.0.0
@wordpress/browserslist-config (source) devDependencies major 5.40.0 -> 6.0.0
@wordpress/browserslist-config (source) dependencies major 5.40.0 -> 6.0.0
@wordpress/browserslist-config (source) devDependencies major 5.39.0 -> 6.0.0
@wordpress/components (source) dependencies major 27.5.0 -> 28.0.0
@wordpress/components (source) devDependencies major 27.5.0 -> 28.0.0
@wordpress/compose (source) dependencies major 6.34.0 -> 7.0.0
@wordpress/core-data (source) devDependencies major 6.34.0 -> 7.0.0
@wordpress/core-data (source) dependencies major 6.34.0 -> 7.0.0
@wordpress/data (source) dependencies major 9.27.0 -> 10.0.0
@wordpress/data (source) dependencies major 9.25.0 -> 10.0.0
@wordpress/data (source) devDependencies major 9.27.0 -> 10.0.0
@wordpress/date (source) dependencies major 4.57.0 -> 5.0.0
@wordpress/date (source) devDependencies major 4.57.0 -> 5.0.0
@wordpress/dependency-extraction-webpack-plugin (source) devDependencies major 5.8.0 -> 6.0.0
@wordpress/dependency-extraction-webpack-plugin (source) devDependencies major 5.7.0 -> 6.0.0
@wordpress/dependency-extraction-webpack-plugin (source) dependencies major 5.8.0 -> 6.0.0
@wordpress/dom-ready (source) devDependencies major 3.57.0 -> 4.0.0
@wordpress/dom-ready (source) dependencies major 3.57.0 -> 4.0.0
@wordpress/dom-ready (source) dependencies major ^3.48.0 -> ^4.0.0
@wordpress/edit-post (source) dependencies major 7.34.0 -> 8.0.0
@wordpress/editor (source) devDependencies major 13.34.0 -> 14.0.0
@wordpress/editor (source) dependencies major 13.34.0 -> 14.0.0
@wordpress/element (source) dependencies major 5.34.0 -> 6.0.0
@wordpress/element (source) dependencies major 5.32.0 -> 6.0.0
@wordpress/element (source) devDependencies major 5.34.0 -> 6.0.0
@wordpress/escape-html (source) devDependencies major 2.57.0 -> 3.0.0
@wordpress/eslint-plugin (source) devDependencies major 18.0.0 -> 19.0.0
@wordpress/format-library (source) devDependencies major 4.34.0 -> 5.0.0
@wordpress/hooks (source) dependencies major 3.57.0 -> 4.0.0
@wordpress/html-entities (source) dependencies major 3.57.0 -> 4.0.0
@wordpress/i18n (source) dependencies major 4.57.0 -> 5.0.0
@wordpress/i18n (source) devDependencies major 4.57.0 -> 5.0.0
@wordpress/i18n (source) peerDependencies major 4.57.0 -> 5.0.0
@wordpress/icons (source) dependencies major 9.48.0 -> 10.0.0
@wordpress/jest-console (source) devDependencies major 7.28.0 -> 8.0.0
@wordpress/keycodes (source) devDependencies major 3.57.0 -> 4.0.0
@wordpress/notices (source) devDependencies major 4.25.0 -> 5.0.0
@wordpress/notices (source) dependencies major 4.25.0 -> 5.0.0
@wordpress/plugins (source) dependencies major 6.25.0 -> 7.0.0
@wordpress/postcss-plugins-preset (source) devDependencies major 4.41.0 -> 5.0.0
@wordpress/primitives (source) dependencies major 3.55.0 -> 4.0.0
@wordpress/token-list (source) devDependencies major 2.57.0 -> 3.0.0
@wordpress/url (source) dependencies major 3.58.0 -> 4.0.0
@wordpress/viewport (source) dependencies major 5.34.0 -> 6.0.0
@wordpress/widgets (source) dependencies major 3.34.0 -> 4.0.0
@wordpress/wordcount (source) dependencies major 3.57.0 -> 4.0.0

Release Notes

WordPress/gutenberg (@​wordpress/annotations)

v3.0.0

Compare Source

Breaking Changes
  • Increase the minimum required Node.js version to v18.12.0 matching long-term support releases (#​31270). Learn more about Node.js releases.

v2.58.0

Compare Source

WordPress/gutenberg (@​wordpress/api-fetch)

v7.0.0

Compare Source

Breaking Changes
  • Increase the minimum required Node.js version to v18.12.0 matching long-term support releases (#​31270). Learn more about Node.js releases.

v6.55.0

Compare Source

WordPress/gutenberg (@​wordpress/babel-plugin-import-jsx-pragma)

v5.0.0

Compare Source

Breaking Changes
  • Increase the minimum required Node.js version to v18.12.0 matching long-term support releases (#​31270). Learn more about Node.js releases.

v4.41.0

Compare Source

WordPress/gutenberg (@​wordpress/babel-preset-default)

v8.0.0

Compare Source

Breaking Changes
  • Use React's automatic runtime to transform JSX (#​61692).
  • Increase the minimum required Node.js version to v18.12.0 matching long-term support releases (#​31270). Learn more about Node.js releases.

v7.42.0

Compare Source

WordPress/gutenberg (@​wordpress/base-styles)

v5.0.0

Compare Source

Breaking Changes
  • Increase the minimum required Node.js version to v18.12.0 matching long-term support releases (#​31270). Learn more about Node.js releases.

v4.49.0

Compare Source

WordPress/gutenberg (@​wordpress/blob)

v4.0.0

Compare Source

Breaking Changes
  • Increase the minimum required Node.js version to v18.12.0 matching long-term support releases (#​31270). Learn more about Node.js releases.

v3.58.0

Compare Source

WordPress/gutenberg (@​wordpress/block-editor)

v13.0.0

Compare Source

Breaking Changes
  • Increase the minimum required Node.js version to v18.12.0 matching long-term support releases (#​31270). Learn more about Node.js releases.

v12.26.0

Compare Source

Internal
  • Replaced classnames package with the faster and smaller clsx package (#​61138).
WordPress/gutenberg (@​wordpress/block-library)

v9.0.0

Compare Source

Breaking Changes
  • Variables like process.env.IS_GUTENBERG_PLUGIN have been replaced by globalThis.IS_GUTENBERG_PLUGIN. Build systems using process.env should be updated (#​61486).
  • Increase the minimum required Node.js version to v18.12.0 matching long-term support releases (#​31270). Learn more about Node.js releases.

v8.35.0

Compare Source

Internal
  • Replaced classnames package with the faster and smaller clsx package (#​61138).
WordPress/gutenberg (@​wordpress/block-serialization-default-parser)

v5.0.0

Compare Source

Breaking Changes
  • Increase the minimum required Node.js version to v18.12.0 matching long-term support releases (#​31270). Learn more about Node.js releases.

v4.58.0

Compare Source

WordPress/gutenberg (@​wordpress/blocks)

v13.0.0

Compare Source

Breaking Changes
  • Variables like process.env.IS_GUTENBERG_PLUGIN have been replaced by globalThis.IS_GUTENBERG_PLUGIN. Build systems using process.env should be updated (#​61486).
  • Increase the minimum required Node.js version to v18.12.0 matching long-term support releases (#​31270). Learn more about Node.js releases.

v12.35.0

Compare Source

WordPress/gutenberg (@​wordpress/browserslist-config)

v6.0.0

Compare Source

Breaking Changes
  • Increase the minimum required Node.js version to v18.12.0 matching long-term support releases (#​31270). Learn more about Node.js releases.

v5.41.0

Compare Source

WordPress/gutenberg (@​wordpress/components)

v28.0.0

Compare Source

Breaking Changes
  • Variables like process.env.IS_GUTENBERG_PLUGIN have been replaced by globalThis.IS_GUTENBERG_PLUGIN. Build systems using process.env should be updated (#​61486).
  • Increase the minimum required Node.js version to v18.12.0 matching long-term support releases (#​31270). Learn more about Node.js releases.
Enhancements
  • Tabs: Animate indicator (#​60560).
  • ComboboxControl: Introduce Combobox expandOnFocus prop (#​61705).
  • ProgressBar: Expose as public API (#​61062).
  • ProgressBar: Simplify default width implementation and make it more easily overridable (#​61976).
Bug Fixes
  • Autocomplete: Stabilize rendering of autocomplete items (#​61877).
  • TabPanel: Make the the focus styles consistent with Tabs. (#​61317).
  • InputControl: Fixed z-index issue where slider dots appeared in front of the Appearance dropdown. (#​61937)
Internal
  • Remove reduceMotion util (#​61963).
  • Add type support for CSS Custom Properties (#​61872).
  • Remove usage of deprecated spreading of key prop in JSX in CustomSelectControl and FormTokenField components (#​61692).
  • Tooltip: Fix Ariakit tooltip store usage (#​61858).
  • CustomSelectControlV2: Use InputBase for styling (#​60261).

v27.6.0

Compare Source

Internal
  • Replaced classnames package with the faster and smaller clsx package (#​61138).
  • Upgrade @use-gesture/react package to ^10.3.1 (#​61503).
  • Upgrade framer-motion package to version ^11.1.9 (#​61572).
Enhancements
Bug Fix
  • ToolsPanel: Fix sticking “Reset” option (#​60621).
  • Fix an issue where types used a synthetic default import (#​61679).
WordPress/gutenberg (@​wordpress/compose)

v7.0.0

Compare Source

Breaking Changes
  • Increase the minimum required Node.js version to v18.12.0 matching long-term support releases (#​31270). Learn more about Node.js releases.

v6.35.0

Compare Source

WordPress/gutenberg (@​wordpress/core-data)

v7.0.0

Compare Source

Breaking Changes
  • Variables like process.env.IS_GUTENBERG_PLUGIN have been replaced by globalThis.IS_GUTENBERG_PLUGIN. Build systems using process.env should be updated (#​61486).
  • Increase the minimum required Node.js version to v18.12.0 matching long-term support releases (#​31270). Learn more about Node.js releases.

v6.35.0

Compare Source

WordPress/gutenberg (@​wordpress/data)

v10.0.0

Compare Source

Breaking Changes
  • Increase the minimum required Node.js version to v18.12.0 matching long-term support releases (#​31270). Learn more about Node.js releases.

v9.28.0

Compare Source

WordPress/gutenberg (@​wordpress/date)

v5.0.0

Compare Source

Breaking Changes
  • Increase the minimum required Node.js version to v18.12.0 matching long-term support releases (#​31270). Learn more about Node.js releases.

v4.58.0

Compare Source

WordPress/gutenberg (@​wordpress/dependency-extraction-webpack-plugin)

v6.0.0

Compare Source

Breaking Changes
  • Increase the minimum required Node.js version to v18.12.0 matching long-term support releases (#​31270). Learn more about Node.js releases.

v5.9.0

Compare Source

WordPress/gutenberg (@​wordpress/dom-ready)

v4.0.0

Compare Source

Breaking Changes
  • Increase the minimum required Node.js version to v18.12.0 matching long-term support releases (#​31270). Learn more about Node.js releases.

v3.58.0

Compare Source

WordPress/gutenberg (@​wordpress/edit-post)

v8.0.0

Compare Source

Breaking Changes
  • Variables like process.env.IS_GUTENBERG_PLUGIN have been replaced by globalThis.IS_GUTENBERG_PLUGIN. Build systems using process.env should be updated (#​61486).
  • Increase the minimum required Node.js version to v18.12.0 matching long-term support releases (#​31270). Learn more about Node.js releases.

v7.35.0

Compare Source

Internal
  • Replaced classnames package with the faster and smaller clsx package (#​61138).
WordPress/gutenberg (@​wordpress/editor)

v14.0.0

Compare Source

Breaking Changes
  • Variables like process.env.IS_GUTENBERG_PLUGIN have been replaced by globalThis.IS_GUTENBERG_PLUGIN. Build systems using process.env should be updated (#​61486).
  • Increase the minimum required Node.js version to v18.12.0 matching long-term support releases (#​31270). Learn more about Node.js releases.

v13.35.0

Compare Source

Internal
  • Replaced classnames package with the faster and smaller clsx package (#​61138).
WordPress/gutenberg (@​wordpress/element)

v6.0.0

Compare Source

Breaking Changes
  • Increase the minimum required Node.js version to v18.12.0 matching long-term support releases (#​31270). Learn more about Node.js releases.

v5.35.0

Compare Source

WordPress/gutenberg (@​wordpress/escape-html)

v3.0.0

Compare Source

Breaking Changes
  • Increase the minimum required Node.js version to v18.12.0 matching long-term support releases (#​31270). Learn more about Node.js releases.

v2.58.0

Compare Source

WordPress/gutenberg (@​wordpress/eslint-plugin)

v19.0.0

Compare Source

Breaking Changes
  • @wordpress/is-gutenberg-plugin rule has been replaced by @wordpress/wp-global-usage (#​61486).
  • @wordpress/wp-process-env rule has been added and included in the recommended configurations (#​61486).
  • @wordpress/gutenberg-phase rule has been removed (deprecated in v10.0.0) (#​61486).
  • Increase the minimum required Node.js version to v18.12.0 matching long-term support releases (#​31270). Learn more about Node.js releases.

v18.1.0

Compare Source

Internal
  • Replaced classnames package with the faster and smaller clsx package (#​61138).
WordPress/gutenberg (@​wordpress/format-library)

v5.0.0

Compare Source

Breaking Changes
  • Increase the minimum required Node.js version to v18.12.0 matching long-term support releases (#​31270). Learn more about Node.js releases.

v4.35.0

Compare Source

WordPress/gutenberg (@​wordpress/hooks)

v4.0.0

Compare Source

Breaking Changes
  • Increase the minimum required Node.js version to v18.12.0 matching long-term support releases (#​31270). Learn more about Node.js releases.

v3.58.0

Compare Source

WordPress/gutenberg (@​wordpress/html-entities)

v4.0.0

Compare Source

Breaking Changes
  • Increase the minimum required Node.js version to v18.12.0 matching long-term support releases (#​31270). Learn more about Node.js releases.

v3.58.0

Compare Source

WordPress/gutenberg (@​wordpress/i18n)

v5.0.0

Compare Source

Breaking Changes
  • Increase the minimum required Node.js version to v18.12.0 matching long-term support releases (#​31270). Learn more about Node.js releases.

v4.58.0

Compare Source

WordPress/gutenberg (@​wordpress/icons)

v10.0.0

Compare Source

Breaking Changes
  • Increase the minimum required Node.js version to v18.12.0 matching long-term support releases (#​31270). Learn more about Node.js releases.

v9.49.0

Compare Source

WordPress/gutenberg (@​wordpress/jest-console)

v8.0.0

Compare Source

Breaking Changes
  • Increase the minimum required Node.js version to v18.12.0 matching long-term support releases (#​31270). Learn more about Node.js releases.

v7.29.0

Compare Source

WordPress/gutenberg (@​wordpress/keycodes)

v4.0.0

Compare Source

Breaking Changes
  • Increase the minimum required Node.js version to v18.12.0 matching long-term support releases (#​31270). Learn more about Node.js releases.

v3.58.0

Compare Source

WordPress/gutenberg (@​wordpress/notices)

v5.0.0

Compare Source

Breaking Changes
  • Increase the minimum required Node.js version to v18.12.0 matching long-term support releases (#​31270). Learn more about Node.js releases.

v4.26.0

Compare Source

WordPress/gutenberg (@​wordpress/plugins)

v7.0.0

Compare Source

Breaking Changes
  • Variables like process.env.IS_GUTENBERG_PLUGIN have been replaced by globalThis.IS_GUTENBERG_PLUGIN. Build systems using process.env should be updated (#​61486).
  • Increase the minimum required Node.js version to v18.12.0 matching long-term support releases (#​31270). Learn more about Node.js releases.

v6.26.0

Compare Source

WordPress/gutenberg (@​wordpress/postcss-plugins-preset)

v5.0.0

Compare Source

Breaking Changes
  • Increase the minimum required Node.js version to v18.12.0 matching long-term support releases (#​31270). Learn more about Node.js releases.

v4.42.0

Compare Source

WordPress/gutenberg (@​wordpress/primitives)

v4.0.0

Compare Source

Breaking Changes
  • Increase the minimum required Node.js version to v18.12.0 matching long-term support releases (#​31270). Learn more about Node.js releases.

v3.56.0

Compare Source

Internal
  • Replaced classnames package with the faster and smaller clsx package (#​61138).
WordPress/gutenberg (@​wordpress/token-list)

v3.0.0

Compare Source

Breaking Changes
  • Increase the minimum required Node.js version to v18.12.0 matching long-term support releases (#​31270). Learn more about Node.js releases.

v2.58.0

Compare Source

WordPress/gutenberg (@​wordpress/url)

v4.0.0

Compare Source

Breaking Changes
  • Increase the minimum required Node.js version to v18.12.0 matching long-term support releases (#​31270). Learn more about Node.js releases.

v3.59.0

Compare Source

WordPress/gutenberg (@​wordpress/viewport)

v6.0.0

Compare Source

Breaking Changes
  • Increase the minimum required Node.js version to v18.12.0 matching long-term support releases (#​31270). Learn more about Node.js releases.

v5.35.0

Compare Source

WordPress/gutenberg (@​wordpress/widgets)

v4.0.0

Compare Source

Breaking Changes
  • Increase the minimum required Node.js version to v18.12.0 matching long-term support releases (#​31270). Learn more about Node.js releases.

v3.35.0

Compare Source

Internal
  • Replaced classnames package with the faster and smaller clsx package (#​61138).
WordPress/gutenberg (@​wordpress/wordcount)

v4.0.0

[Com


Configuration

📅 Schedule: Branch creation - "before 3am on the first day of the month" in timezone UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@github-actions github-actions bot added [Plugin] Classic Theme Helper Plugin [Plugin] CRM Issues about the Jetpack CRM plugin [Plugin] Inspect [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Migration [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. RNA labels Jun 1, 2024
Copy link
Contributor

github-actions bot commented Jun 1, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the renovate/wordpress-monorepo branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack renovate/wordpress-monorepo
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin renovate/wordpress-monorepo
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@matticbot matticbot force-pushed the renovate/wordpress-monorepo branch from b55806f to 39240f7 Compare June 3, 2024 19:58
@anomiex
Copy link
Contributor

anomiex commented Jun 3, 2024

Something in here seems to be breaking the Jetpack dashboard, need to figure that out. That seems to be why all the E2Es are failing.

@matticbot
Copy link
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@anomiex
Copy link
Contributor

anomiex commented Jun 3, 2024

Looks like it's probably WordPress/gutenberg#62202. Everything seems to start working if you install the Gutenberg plugin nightly build.

@anomiex anomiex enabled auto-merge (squash) June 4, 2024 16:44
Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stuff seems to work now.

@anomiex anomiex merged commit 3273e03 into trunk Jun 4, 2024
71 of 72 checks passed
@anomiex anomiex deleted the renovate/wordpress-monorepo branch June 4, 2024 16:44
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Calypsoify [Feature] Contact Form [Feature] Masterbar WordPress.com Toolbar and Dashboard customizations [Feature] Theme Tools [JS Package] AI Client [JS Package] API [JS Package] Base Styles [JS Package] Boost Score Api [JS Package] Components [JS Package] Connection [JS Package] Eslint Config Target Es [JS Package] I18n Loader Webpack Plugin [JS Package] IDC [JS Package] Licensing [JS Package] Partner Coupon [JS Package] Publicize Components [JS Package] Scan [JS Package] Shared Extension Utils [JS Package] Storybook [JS Package] Webpack Config [Package] Ad aka WordAds [Package] Assets [Package] Backup [Package] Blaze [Package] Calypsoify [Package] Classic Theme Helper [Package] Connection [Package] Forms [Package] Jetpack mu wpcom WordPress.com Features [Package] Jitm [Package] Lazy Images This package no longer exists in the monorepo. [Package] Masterbar [Package] My Jetpack [Package] Publicize [Package] Search Contains core Search functionality for Jetpack and Search plugins [Package] VideoPress [Package] Yoast Promo [Plugin] Automattic For Agencies Client [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Classic Theme Helper Plugin [Plugin] CRM Issues about the Jetpack CRM plugin [Plugin] Inspect [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Migration [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. RNA [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants