-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AI Inline Extensions: Support custom behavior #37634
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
projects/plugins/jetpack/extensions/blocks/ai-assistant/inline-extensions/with-ai-extension.tsx
Outdated
Show resolved
Hide resolved
projects/plugins/jetpack/extensions/blocks/ai-assistant/inline-extensions/block-handler.tsx
Outdated
Show resolved
Hide resolved
c6943e9
to
6bd5466
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code makes sense is working as described:
- I can't see the compiler errors mentioned by Douglas, so I think you solved the issues
- I was able to add custom behavior to the paragraph and get the context on a click
- I was able to add custom behavior to the list item and get the context of it's parent on a click
Nice addition!
Related with #37590
Proposed changes:
list-item
aschildrenBlock
.Other information:
Jetpack product discussion
N/A
Does this pull request change what data or activity we track or use?
N/A
Testing instructions:
handleBehavior
).constructor
aftersuper
call:this.behavior = this.handleBehavior
.log
the parameters (withcontext
).list-item
you need to receive the parent context (list
).