Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI Inline Extensions: Support custom behavior #37634

Merged
merged 6 commits into from
May 31, 2024

Conversation

renatoagds
Copy link
Contributor

Related with #37590

Proposed changes:

  • Support a custom behavior passing through a function.
  • Export actions through context if isn't a children block.
  • Mark list-item as childrenBlock.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

N/A

Testing instructions:

  • Go to some block class handler (ex. paragraph).
  • Add a method to handle the behavior (ex. handleBehavior).
  • Expose it on constructor after super call: this.behavior = this.handleBehavior.
  • You should be able to log the parameters (with context).
  • If you do the same on list-item you need to receive the parent context (list).

@renatoagds renatoagds requested a review from a team May 29, 2024 23:00
@renatoagds renatoagds self-assigned this May 29, 2024
@github-actions github-actions bot added [Block] AI Assistant [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels May 29, 2024
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for June 4, 2024 (scheduled code freeze on June 3, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link
Contributor

github-actions bot commented May 29, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/ai-inline-extensions-custom-behavior branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack add/ai-inline-extensions-custom-behavior
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@renatoagds renatoagds force-pushed the add/ai-inline-extensions-custom-behavior branch from c6943e9 to 6bd5466 Compare May 31, 2024 18:45
Copy link
Contributor

@lhkowalski lhkowalski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense is working as described:

  • I can't see the compiler errors mentioned by Douglas, so I think you solved the issues
  • I was able to add custom behavior to the paragraph and get the context on a click
  • I was able to add custom behavior to the list item and get the context of it's parent on a click

Nice addition!

@renatoagds renatoagds merged commit 4659a6f into trunk May 31, 2024
56 checks passed
@renatoagds renatoagds deleted the add/ai-inline-extensions-custom-behavior branch May 31, 2024 21:21
@github-actions github-actions bot added this to the jetpack/13.5 milestone May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] AI Assistant [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants