-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contact Form: add date format to date picker #34743
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, Kevin!
I tested this with a JN site on latest stable, added a contact form with a date field and then switched to this branch to view/edit the existing form.
Upon viewing I got the following warning:
Warning: Undefined array key "formTitle" in [REDACTED]/wp-content/plugins/jetpack-dev/jetpack_vendor/automattic/jetpack-forms/src/contact-form/class-contact-form.php on line 357
Also, very minor but when editing the form the placeholder I had in place seemed to lose its padding:
Thanks @fgiannar!
Good catch! I think this one was introduced by this PR: #34667. I'll create a new PR to suppress the warning.
Nice finding. I could reproduce the issue (with all text inputs), but not consistently. The padding is determined by reading the padding value of a "probe" component (see this line) and I suppose this style probing is sometimes done before all CSS is loaded. That should probably be handled separately too. |
be1ee64
to
c7173c0
Compare
d4761be
to
c7173c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested once more on both JN and Simple sites and apart from the original findings that will be addressed in follow-up PRs, everything works as expected 👍
Fixes #34501
Proposed changes:
The jQuery UI Datepicker widget used by the Date Picker field of the Contact Form can't be used with a keyboard. This PR adds a date format to the field so keyboard users know how to fill out the form without opening the picker.
Other information:
Jetpack product discussion
Project thread: pf5801-87-p2
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
Prerequisites
cd projects/packages/forms && npm run build
Editor
Site