Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Social: Fix auto-conversion cleanup logic #34666

Merged
merged 3 commits into from
Dec 15, 2023
Merged

Social: Fix auto-conversion cleanup logic #34666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e86d71f
Fix logic to be mindful of absent option
gmjuhasz Dec 15, 2023
0445b99
changelog
gmjuhasz Dec 15, 2023
f8fef20
Fixup versions
gmjuhasz Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/packages/publicize/changelog/fix-social-auto-conversion-cleanup-logic
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fixed

Social: Fixed issue with auto-conversion option logic
2 changes: 1 addition & 1 deletion projects/packages/publicize/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"private": true,
"name": "@automattic/jetpack-publicize",
"version": "0.38.1",
"version": "0.38.2-alpha",
"description": "Publicize makes it easy to share your site’s posts on several social media networks automatically when you publish a new post.",
"homepage": "https://github.com/Automattic/jetpack/tree/HEAD/projects/packages/publicize/#readme",
"bugs": {
Expand Down
4 changes: 3 additions & 1 deletion projects/packages/publicize/src/jetpack-social-settings/class-settings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,9 @@ private function migrate_old_option() {
}
// Checking if the new option is valid.
$auto_conversion_settings = get_option( self::OPTION_PREFIX . self::AUTOCONVERT_IMAGES );
if ( ! is_array( $auto_conversion_settings ) || ! isset( $auto_conversion_settings['enabled'] ) ) {
// If the option is not set, we don't need to delete it.
// If it is set, but it is not an array or it does not have the enabled key, we delete it.
if ( false !== $auto_conversion_settings && ( ! is_array( $auto_conversion_settings ) || ! isset( $auto_conversion_settings['enabled'] ) ) ) {
delete_option( self::OPTION_PREFIX . self::AUTOCONVERT_IMAGES );
}

Expand Down
Loading