-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async load business hours and blogging prompt blocks #32256
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
@@ -93,5 +93,6 @@ | |||
"tock", | |||
"videopress", | |||
"wordads" | |||
] | |||
], | |||
"_bundles": { "test": [ "blogging-prompt", "business-hours" ] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we don't need to name bundles, this might as well be:
"_bundles": [
[ "blogging-prompt", "business-hours" ], // bundled blocks
"ai-chat" // single block
]
This PR has been marked as stale. This happened because:
If this PR is still useful, please do a [trunk merge or rebase](https://github.com/Automattic/jetpack/blob/trunk/docs/git-workflow.md#keeping-your-branch-up-to-date) and otherwise make sure it's up to date and has clear testing instructions. You may also want to ping possible reviewers in case they've forgotten about it. Please close this PR if you think it's not valid anymore — if you do, please add a brief explanation. If the PR is not updated (or at least commented on) in another month, it will be automatically closed. |
Proposed changes:
Load Business Hours and Blogging Prompt blocks asynchronously. This is a proof-of-concept.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
Prerequisites
jetpack
repo, link the Gutenberg plugin to your local folder intools/docker/jetpack-docker-config-default.yml
by adding<path to your Gutenberg folder>: /var/www/html/wp-content/plugins/gutenberg
in thevolumeMappings
keyTesting
TBD