-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metadata file to blogging-prompt and business-hours blocks #32187
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
Could we split the work to utilize the block.json from the block.json addition themselves? I'm not sure why the meta dir things are needed for first step of having visibility in w.org? |
It was required to test the registering approach, but since just including the metadata file in the directory works, no need for it indeed. We'll work in new PRs. |
Proposed changes:
This PR adds a
block.json
metadata file to theblogging-prompt
andbusiness-hours
blocks and updates the build so that these files are copied over to the build folder.This is an attempt to see if wp.org will parse the metadata file by just including it in a block directory.
Other information:
Jetpack product discussion
pedMtX-RS-p2
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
TBD