Sharing: add new Skype sharing button #3171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeherve
added
[Type] Enhancement
| public function __construct( $id, array $settings ) { | ||
| parent::__construct( $id, $settings ); | ||
|
|
||
| if ( isset( $settings['share_type'] ) ) |
There was a problem hiding this comment.
Please add curly braces in the conditionals here.
zinigor
added
[Status] Ready to Merge
|
Left two minor comments, otherwise this works great, thanks! |
jeherve
added a commit
to jeherve/jetpack
that referenced
this pull request
Jan 4, 2016
|
|
nice
dereksmart
added a commit
that referenced
this pull request
Jan 11, 2016
Sharing: add new Skype sharing button
dereksmart
removed
the
[Status] Ready to Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3170
You'll need to run
gruntto see the button styles in the dashboard.