Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writing prompt block: a few cleanup tasks #29324

Merged
merged 3 commits into from
Mar 7, 2023

Conversation

creativecoder
Copy link
Contributor

@creativecoder creativecoder commented Mar 6, 2023

Proposed changes:

Follow up to #29189

  • Uses scss variables from @automattic/jetpack-base-styles/gutenberg-base-styles where appropriate
  • Ensures "View all responses" is an external link that opens in a new tab/window
  • Ensures "prompt" is used in css classes and the like, since a block represents a single prompt

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

pe7F0s-uo-p2

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

Note that this block currently requires API changes that haven't been released to WP.com yet

  • Set up your wpcom sandbox for testing by applying Jepack trunk to your sandbox with bin/jetpack-downloader test jetpack trunk
  • Set the JETPACK__SANDBOX_DOMAIN constant to your wpcom sandbox host, using a define statement on your development site, or Settings > Jetpack Constants on your jurassic.ninja site.
  • Make sure your site is connected to WP.com (you will need to use local tunneling if using a local dev site PCYsg-GJ2-p2)
  • Insert a block, make sure block options work as expected, and save
  • Check that the block displays correctly on the front end and clicking "View all responses" opens in a new tab/window
  • Reload the post where you have the block, and make sure there are no block validation errors

@creativecoder creativecoder added the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Mar 6, 2023
@creativecoder creativecoder self-assigned this Mar 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run

bin/jetpack-downloader test jetpack update/blogging-prompt-block-cleanup

to get started. More details: p9dueE-5Nn-p2

@github-actions github-actions bot added [Block] Blogging Prompt [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Mar 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: April 4, 2023.
  • Scheduled code freeze: March 28, 2023.

@creativecoder
Copy link
Contributor Author

@jeherve Here's the followup we discussed in #29189

Unfortunately I couldn't get the ExternalLink component to work in the save function. (Logged an issue here, but this may be a known problem).

@creativecoder creativecoder requested review from jeherve and a team March 6, 2023 22:41
Copy link
Contributor

@roo2 roo2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! tested on wpcom.

@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Mar 7, 2023
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Mar 7, 2023
@creativecoder creativecoder merged commit 34dc9c3 into trunk Mar 7, 2023
@creativecoder creativecoder deleted the update/blogging-prompt-block-cleanup branch March 7, 2023 15:42
@github-actions github-actions bot added this to the jetpack/12.0 milestone Mar 7, 2023
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 7, 2023
TimBroddin added a commit that referenced this pull request Mar 8, 2023
commit e426f62
Merge: 0f2a0f4 0712aed
Author: Tim Broddin <[email protected]>
Date:   Wed Mar 8 12:37:40 2023 +0100

    Merge branch 'trunk' into add/map-block-mapkit

commit 0712aed
Author: thingalon <[email protected]>
Date:   Wed Mar 8 20:00:50 2023 +1100

    [Boost] Clean up linting issues in the minify feature (#29352)

    * Fix linting issues in minify module

    * changelog

    ---------

    Co-authored-by: Mark George <[email protected]>

commit 12fbcf8
Author: Nauris Pūķis <[email protected]>
Date:   Wed Mar 8 09:45:29 2023 +0200

    Jetpack Boost: Add livereload (#29342)

    * Add livereload to the run dev script

    * Move livereaload functionality to "devlive" script

    * Add a bit of documentation 🤏

    * Add a changelog

commit 0dcad49
Author: Francesco Bigiarini <[email protected]>
Date:   Wed Mar 8 08:32:37 2023 +0100

    Add import package media endpoints (#29080)

    * [not verified] Add /jetpack/v4/import/media/* endpoints

    * [not verified] changelog

    * [not verified] Fix: remove categories and tags from pages.

    * [not verified] Add attachment PUT method

    * [not verified] Fix: wrong variable name

    * [not verified] Add missing body action

    * [not verified] Update version

commit cf08052
Author: thingalon <[email protected]>
Date:   Wed Mar 8 17:54:09 2023 +1100

    Add a changelog for fixing Safari lazy loading for the next boost release (#29266)

    Co-authored-by: Mark George <[email protected]>

commit 318799a
Author: Nate Weller <[email protected]>
Date:   Tue Mar 7 22:44:08 2023 -0700

    Protect: Display "All threats" instead of "All 1 threats" (#29327)

commit 39f711e
Author: Samiff <[email protected]>
Date:   Tue Mar 7 15:10:52 2023 -0700

    Update/jetpack backport 11.9 (#29345)

    * [not verified] Jetpack: 11.9 changelog and readme

    * Update stable tag to 11.9

commit e480211
Author: Matthew Reishus <[email protected]>
Date:   Tue Mar 7 14:35:16 2023 -0600

    media summary: write to memo when no images found (#29326)

commit 177950e
Author: Jason Johnston <[email protected]>
Date:   Tue Mar 7 15:25:17 2023 -0500

    VideoPress: Add/use preview hook (#29164)

    * [not verified] Add usePreview hook

    * [not verified] Use UsePreview hook

    * [not verified] Add changelog

    * Update projects/packages/videopress/src/client/block-editor/hooks/use-preview.ts

    Co-authored-by: Damián Suárez <[email protected]>

    * Move hook to a directory

    Add readme

    * Update VideoPress version

    * Fix package path

    ---------

    Co-authored-by: jhnstn <[email protected]>
    Co-authored-by: Damián Suárez <[email protected]>

commit dff2d71
Author: Nate Weller <[email protected]>
Date:   Tue Mar 7 11:33:25 2023 -0700

    Protect: More Descriptive Error Messages (#29185)

commit fc9b6b5
Author: Nate Weller <[email protected]>
Date:   Tue Mar 7 11:14:12 2023 -0700

    WAF: Minor Error Handling Improvements (#29108)

commit 128facd
Author: Damián Suárez <[email protected]>
Date:   Tue Mar 7 15:00:53 2023 -0300

    VideoPress: pick and convert core/video VideoPress instances also from inner blocks (#29339)

    * pick v6 also from inner blocks

    * changelog

    * minor code changes

    * fix changelog

    * minor doc enhancement

    * ensure to include the selected v5 instance

commit 34dc9c3
Author: Grant Kinney <[email protected]>
Date:   Tue Mar 7 09:42:49 2023 -0600

    Writing prompt block: a few cleanup tasks (#29324)

    - Uses scss variables from @automattic/jetpack-base-styles/gutenberg-base-styles where appropriate
    - Ensures "View all responses" is an external link that opens in a new tab/window
    - Ensures "prompt" is used in css classes and the like, since a block represents a single prompt

commit 76990eb
Author: Kuba Birecki <[email protected]>
Date:   Tue Mar 7 15:56:37 2023 +0100

    Implement RWD navigation for feedback dashboard (#29315)

    * [not verified] Fix RWD styles for the table and response

    * [not verified] Add navigation for switching between inbox and response views on mobile

    * Update layout component to accept custom class names

    * changelog
TimBroddin added a commit that referenced this pull request Mar 9, 2023
* Cherry-pick hook

* Cherry-pick

* WIP

* Markers & info window

* WIP useEffect dependency cleanup

* - MapRef for resizing
- Better zooming for multiple markers

* Some cleanup

* - Disable zoom control on map when we have more than 1 point

* Sane defaults when adding a map

* Remove TODO

* Add changelog

* Merge with location search

* Make check for mapRef more compact

* Rename createCalloutElement to createCalloutElementCallback

* Update style code styling

* Remove todo and add linebreak between import & function call

* Code style fix

* InfoWindow renaming

* Remove commented out console.log

* Mapkit doesn't have id's for places returned, so create one

* Fix resizing doing bad things

* Load Mapkit only once

* Load Mapkit only once (frontend)

* Make cookie override frontend too

* Changelog

* Show error when Mapkit API request fails

* Changelog

* Friendlier error message

* Squashed commit of the following:

commit e426f62
Merge: 0f2a0f4 0712aed
Author: Tim Broddin <[email protected]>
Date:   Wed Mar 8 12:37:40 2023 +0100

    Merge branch 'trunk' into add/map-block-mapkit

commit 0712aed
Author: thingalon <[email protected]>
Date:   Wed Mar 8 20:00:50 2023 +1100

    [Boost] Clean up linting issues in the minify feature (#29352)

    * Fix linting issues in minify module

    * changelog

    ---------

    Co-authored-by: Mark George <[email protected]>

commit 12fbcf8
Author: Nauris Pūķis <[email protected]>
Date:   Wed Mar 8 09:45:29 2023 +0200

    Jetpack Boost: Add livereload (#29342)

    * Add livereload to the run dev script

    * Move livereaload functionality to "devlive" script

    * Add a bit of documentation 🤏

    * Add a changelog

commit 0dcad49
Author: Francesco Bigiarini <[email protected]>
Date:   Wed Mar 8 08:32:37 2023 +0100

    Add import package media endpoints (#29080)

    * [not verified] Add /jetpack/v4/import/media/* endpoints

    * [not verified] changelog

    * [not verified] Fix: remove categories and tags from pages.

    * [not verified] Add attachment PUT method

    * [not verified] Fix: wrong variable name

    * [not verified] Add missing body action

    * [not verified] Update version

commit cf08052
Author: thingalon <[email protected]>
Date:   Wed Mar 8 17:54:09 2023 +1100

    Add a changelog for fixing Safari lazy loading for the next boost release (#29266)

    Co-authored-by: Mark George <[email protected]>

commit 318799a
Author: Nate Weller <[email protected]>
Date:   Tue Mar 7 22:44:08 2023 -0700

    Protect: Display "All threats" instead of "All 1 threats" (#29327)

commit 39f711e
Author: Samiff <[email protected]>
Date:   Tue Mar 7 15:10:52 2023 -0700

    Update/jetpack backport 11.9 (#29345)

    * [not verified] Jetpack: 11.9 changelog and readme

    * Update stable tag to 11.9

commit e480211
Author: Matthew Reishus <[email protected]>
Date:   Tue Mar 7 14:35:16 2023 -0600

    media summary: write to memo when no images found (#29326)

commit 177950e
Author: Jason Johnston <[email protected]>
Date:   Tue Mar 7 15:25:17 2023 -0500

    VideoPress: Add/use preview hook (#29164)

    * [not verified] Add usePreview hook

    * [not verified] Use UsePreview hook

    * [not verified] Add changelog

    * Update projects/packages/videopress/src/client/block-editor/hooks/use-preview.ts

    Co-authored-by: Damián Suárez <[email protected]>

    * Move hook to a directory

    Add readme

    * Update VideoPress version

    * Fix package path

    ---------

    Co-authored-by: jhnstn <[email protected]>
    Co-authored-by: Damián Suárez <[email protected]>

commit dff2d71
Author: Nate Weller <[email protected]>
Date:   Tue Mar 7 11:33:25 2023 -0700

    Protect: More Descriptive Error Messages (#29185)

commit fc9b6b5
Author: Nate Weller <[email protected]>
Date:   Tue Mar 7 11:14:12 2023 -0700

    WAF: Minor Error Handling Improvements (#29108)

commit 128facd
Author: Damián Suárez <[email protected]>
Date:   Tue Mar 7 15:00:53 2023 -0300

    VideoPress: pick and convert core/video VideoPress instances also from inner blocks (#29339)

    * pick v6 also from inner blocks

    * changelog

    * minor code changes

    * fix changelog

    * minor doc enhancement

    * ensure to include the selected v5 instance

commit 34dc9c3
Author: Grant Kinney <[email protected]>
Date:   Tue Mar 7 09:42:49 2023 -0600

    Writing prompt block: a few cleanup tasks (#29324)

    - Uses scss variables from @automattic/jetpack-base-styles/gutenberg-base-styles where appropriate
    - Ensures "View all responses" is an external link that opens in a new tab/window
    - Ensures "prompt" is used in css classes and the like, since a block represents a single prompt

commit 76990eb
Author: Kuba Birecki <[email protected]>
Date:   Tue Mar 7 15:56:37 2023 +0100

    Implement RWD navigation for feedback dashboard (#29315)

    * [not verified] Fix RWD styles for the table and response

    * [not verified] Add navigation for switching between inbox and response views on mobile

    * Update layout component to accept custom class names

    * changelog

* Reject when mapkitIsInitializing is undefined

* Delete changelogs

---------

Co-authored-by: Maciej Grabowski <[email protected]>
TimBroddin added a commit that referenced this pull request Apr 26, 2023
* Add util functions to convert from/between Mapbox zoom levels & Mapkit camera distance (#29092)

* Add helper functions to convert from & to zoom level

* Add helper functions to convert from & to zoom level

* Simplified convertCameraDistanceToZoomLevel

* Add `getMapProvider` helper (#29116)

* [not verified] Add util functions to convert from/between Mapbox zoom levels & Mapkit camera distance (#29092)

* Add helper functions to convert from & to zoom level

* Add helper functions to convert from & to zoom level

* Simplified convertCameraDistanceToZoomLevel

* [not verified] Add `getMapProvider` helper (#29116)

* Introduce useMapkitSetup hook (#29144)

* Introduce useMapkitSetup hook

* Cherry-pick

* Cherry-pick

* Add changelog

* Maps block: render Apple Maps maps on WP.com frontend (#29089)

* [not verified] WIP version of Mapkit support

* [not verified] Changelog

* Implement convertZoomLevelToCameraDistance

* - Size map according to what's inside data-map-height.
- Move resizeMapContainer to utils

* - Resize logic for Mapkit

* Rename sources to view

* Fix inclusion of React, Lodash & others

* Add support for Mapkit geocoding (#29120)

* Add Mapkit geocoding

* Add changelog

* Fix focus

* Skip POI's

* - Use async/await where possible to reduce code and increase readability

* Don't fetch user location for geosearch

* fetchKey function returns a promise

* Fallback to [] when results is null

* Don't show Mapbox token input when map provider is Mapkit (#29306)

* Hide access token panel when provider is not mapbox

* Add changelog

* Add Mapkit support in the editor (#29252)

* Cherry-pick hook

* Cherry-pick

* WIP

* Markers & info window

* WIP useEffect dependency cleanup

* - MapRef for resizing
- Better zooming for multiple markers

* Some cleanup

* - Disable zoom control on map when we have more than 1 point

* Sane defaults when adding a map

* Remove TODO

* Add changelog

* Merge with location search

* Make check for mapRef more compact

* Rename createCalloutElement to createCalloutElementCallback

* Update style code styling

* Remove todo and add linebreak between import & function call

* Code style fix

* InfoWindow renaming

* Remove commented out console.log

* Mapkit doesn't have id's for places returned, so create one

* Fix resizing doing bad things

* Revert "Add Mapkit support in the editor (#29252)" (#29353)

This reverts commit 8b79eab.

* Revert "Revert "Add Mapkit support in the editor (#29252)" (#29353)" (#29354)

This reverts commit 5ac39b1.

* Only show specific controls when mapprovider is mapbox (#29333)

* Only show specific controls when mapprovider is mapbox

* Add tests

* Add changelog

* Only load Mapkit library block once per page (#29301)

* Cherry-pick hook

* Cherry-pick

* WIP

* Markers & info window

* WIP useEffect dependency cleanup

* - MapRef for resizing
- Better zooming for multiple markers

* Some cleanup

* - Disable zoom control on map when we have more than 1 point

* Sane defaults when adding a map

* Remove TODO

* Add changelog

* Merge with location search

* Make check for mapRef more compact

* Rename createCalloutElement to createCalloutElementCallback

* Update style code styling

* Remove todo and add linebreak between import & function call

* Code style fix

* InfoWindow renaming

* Remove commented out console.log

* Mapkit doesn't have id's for places returned, so create one

* Fix resizing doing bad things

* Load Mapkit only once

* Load Mapkit only once (frontend)

* Make cookie override frontend too

* Changelog

* Reject when mapkitIsInitializing is undefined

---------

Co-authored-by: Maciej Grabowski <[email protected]>

* Recenter map after closing a marker info window (#29338)

* Cherry-pick hook

* Cherry-pick

* WIP

* Markers & info window

* WIP useEffect dependency cleanup

* - MapRef for resizing
- Better zooming for multiple markers

* Some cleanup

* - Disable zoom control on map when we have more than 1 point

* Sane defaults when adding a map

* Remove TODO

* Add changelog

* Merge with location search

* Make check for mapRef more compact

* Rename createCalloutElement to createCalloutElementCallback

* Update style code styling

* Remove todo and add linebreak between import & function call

* Code style fix

* InfoWindow renaming

* Remove commented out console.log

* Mapkit doesn't have id's for places returned, so create one

* Fix resizing doing bad things

* Recenter map when closing popup

* Changelog

* Move logic to getMapProvider (#29382)

* Move logic to getMapProvider

* Changelog

* Also make a get_map_provider function on the server side

* Change str_contains to str_pos since str_contains is only supported in PHP7.4+

* Geocode the address attribute if it's present (#29394)

* Geocode address if it's an attribute

* Changelog

* Round zoom level value in block controls (#29334)

* Cherry-pick hook

* Cherry-pick

* WIP

* Markers & info window

* WIP useEffect dependency cleanup

* - MapRef for resizing
- Better zooming for multiple markers

* Some cleanup

* - Disable zoom control on map when we have more than 1 point

* Sane defaults when adding a map

* Remove TODO

* Add changelog

* Merge with location search

* Make check for mapRef more compact

* Rename createCalloutElement to createCalloutElementCallback

* Update style code styling

* Remove todo and add linebreak between import & function call

* Code style fix

* InfoWindow renaming

* Remove commented out console.log

* Mapkit doesn't have id's for places returned, so create one

* Fix resizing doing bad things

* Round zoom value

* Catch Mapkit API request failures & show error (#29356)

* Cherry-pick hook

* Cherry-pick

* WIP

* Markers & info window

* WIP useEffect dependency cleanup

* - MapRef for resizing
- Better zooming for multiple markers

* Some cleanup

* - Disable zoom control on map when we have more than 1 point

* Sane defaults when adding a map

* Remove TODO

* Add changelog

* Merge with location search

* Make check for mapRef more compact

* Rename createCalloutElement to createCalloutElementCallback

* Update style code styling

* Remove todo and add linebreak between import & function call

* Code style fix

* InfoWindow renaming

* Remove commented out console.log

* Mapkit doesn't have id's for places returned, so create one

* Fix resizing doing bad things

* Load Mapkit only once

* Load Mapkit only once (frontend)

* Make cookie override frontend too

* Changelog

* Show error when Mapkit API request fails

* Changelog

* Friendlier error message

* Squashed commit of the following:

commit e426f62
Merge: 0f2a0f4 0712aed
Author: Tim Broddin <[email protected]>
Date:   Wed Mar 8 12:37:40 2023 +0100

    Merge branch 'trunk' into add/map-block-mapkit

commit 0712aed
Author: thingalon <[email protected]>
Date:   Wed Mar 8 20:00:50 2023 +1100

    [Boost] Clean up linting issues in the minify feature (#29352)

    * Fix linting issues in minify module

    * changelog

    ---------

    Co-authored-by: Mark George <[email protected]>

commit 12fbcf8
Author: Nauris Pūķis <[email protected]>
Date:   Wed Mar 8 09:45:29 2023 +0200

    Jetpack Boost: Add livereload (#29342)

    * Add livereload to the run dev script

    * Move livereaload functionality to "devlive" script

    * Add a bit of documentation 🤏

    * Add a changelog

commit 0dcad49
Author: Francesco Bigiarini <[email protected]>
Date:   Wed Mar 8 08:32:37 2023 +0100

    Add import package media endpoints (#29080)

    * [not verified] Add /jetpack/v4/import/media/* endpoints

    * [not verified] changelog

    * [not verified] Fix: remove categories and tags from pages.

    * [not verified] Add attachment PUT method

    * [not verified] Fix: wrong variable name

    * [not verified] Add missing body action

    * [not verified] Update version

commit cf08052
Author: thingalon <[email protected]>
Date:   Wed Mar 8 17:54:09 2023 +1100

    Add a changelog for fixing Safari lazy loading for the next boost release (#29266)

    Co-authored-by: Mark George <[email protected]>

commit 318799a
Author: Nate Weller <[email protected]>
Date:   Tue Mar 7 22:44:08 2023 -0700

    Protect: Display "All threats" instead of "All 1 threats" (#29327)

commit 39f711e
Author: Samiff <[email protected]>
Date:   Tue Mar 7 15:10:52 2023 -0700

    Update/jetpack backport 11.9 (#29345)

    * [not verified] Jetpack: 11.9 changelog and readme

    * Update stable tag to 11.9

commit e480211
Author: Matthew Reishus <[email protected]>
Date:   Tue Mar 7 14:35:16 2023 -0600

    media summary: write to memo when no images found (#29326)

commit 177950e
Author: Jason Johnston <[email protected]>
Date:   Tue Mar 7 15:25:17 2023 -0500

    VideoPress: Add/use preview hook (#29164)

    * [not verified] Add usePreview hook

    * [not verified] Use UsePreview hook

    * [not verified] Add changelog

    * Update projects/packages/videopress/src/client/block-editor/hooks/use-preview.ts

    Co-authored-by: Damián Suárez <[email protected]>

    * Move hook to a directory

    Add readme

    * Update VideoPress version

    * Fix package path

    ---------

    Co-authored-by: jhnstn <[email protected]>
    Co-authored-by: Damián Suárez <[email protected]>

commit dff2d71
Author: Nate Weller <[email protected]>
Date:   Tue Mar 7 11:33:25 2023 -0700

    Protect: More Descriptive Error Messages (#29185)

commit fc9b6b5
Author: Nate Weller <[email protected]>
Date:   Tue Mar 7 11:14:12 2023 -0700

    WAF: Minor Error Handling Improvements (#29108)

commit 128facd
Author: Damián Suárez <[email protected]>
Date:   Tue Mar 7 15:00:53 2023 -0300

    VideoPress: pick and convert core/video VideoPress instances also from inner blocks (#29339)

    * pick v6 also from inner blocks

    * changelog

    * minor code changes

    * fix changelog

    * minor doc enhancement

    * ensure to include the selected v5 instance

commit 34dc9c3
Author: Grant Kinney <[email protected]>
Date:   Tue Mar 7 09:42:49 2023 -0600

    Writing prompt block: a few cleanup tasks (#29324)

    - Uses scss variables from @automattic/jetpack-base-styles/gutenberg-base-styles where appropriate
    - Ensures "View all responses" is an external link that opens in a new tab/window
    - Ensures "prompt" is used in css classes and the like, since a block represents a single prompt

commit 76990eb
Author: Kuba Birecki <[email protected]>
Date:   Tue Mar 7 15:56:37 2023 +0100

    Implement RWD navigation for feedback dashboard (#29315)

    * [not verified] Fix RWD styles for the table and response

    * [not verified] Add navigation for switching between inbox and response views on mobile

    * Update layout component to accept custom class names

    * changelog

* Reject when mapkitIsInitializing is undefined

* Delete changelogs

---------

Co-authored-by: Maciej Grabowski <[email protected]>

* Default to the default mapCenter defined in settings.js (#29385)

* Default center

* Changelog

* Should be MutedStandard.

* Call hook to get map provider

* Read window global in getMapProvider

* Reformat error

* Allow scroll to zoom for mapkit

* Map black & white to MutedStandard on Mapkit

* Better type check

* Fix test

* Change label for Black & White option to Muted on Mapkit
Change screenshots to Mapkit version on Mapkit

* Fix minification build problem

* Fix minification build problem

* Fix minification build problem

* Mapkit token didn't work on private sites, changed this to proxy via /wp-json

* Call renamed endpoint

* Call renamed endpoint

* Remove helper class & separate endpoint for now

* Update get-map-provider to accomodate new shape of global

* Change global variable name to Jetpack_Maps

---------

Co-authored-by: Maciej Grabowski <[email protected]>
Co-authored-by: Yan Sern <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Blogging Prompt [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants