Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Jetpack: Requires/Push to connection only if needed #27615

Merged
merged 7 commits into from
Dec 2, 2022

Conversation

renatoagds
Copy link
Contributor

@renatoagds renatoagds commented Nov 25, 2022

Closes #27608
Closes #27612
Closes #27611
Closes #27695

Changes proposed in this Pull Request:

  • Push user to connection page only when activating and only if needed.
  • Update ProductDetailCard to use useProductCheckoutWorkflow.
  • Update get_products_from_wpcom to use endpoint based on user connection.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

Fully Disconnected with Jetpack plugin

⚠️ Make sure that you're fully or user disconnected.

  • Navigate to My Jetpack.
  • You should be able to:
    • Add (install) a new product that doesn't require purchase, and be redirect to it (CRM, Akismet for ex.)
    • Purchase a new product, being requested to connect first (Backup, Search for ex.).
    • Activate a module, being moved to connect screen first.

Fully/User Disconnected with Standalone plugin

⚠️ Make sure that you're fully or user disconnected.

  • Navigate to My Jetpack.
  • You should be able to:
    • Add (install) a new product that doesn't require purchase, and be redirect to it (CRM, Akismet for ex.)
    • Purchase a new product, being requested to connect first (Backup, Search for ex.).

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2022

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run bin/jetpack-downloader test jetpack update/my-jetpack-activate-while-disconnected to get started. More details: p9dueE-5Nn-p2

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Nov 25, 2022
@renatoagds renatoagds added [Status] In Progress and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Nov 25, 2022
@renatoagds renatoagds changed the title My Jetpack: Requires connection only if needed My Jetpack: Requires/Push to connection only if needed Dec 1, 2022
@nunyvega
Copy link

nunyvega commented Dec 1, 2022

I'm getting this error in the console when opening My Jetpack
Screenshot 2022-12-01 at 11 25 36

@nunyvega
Copy link

nunyvega commented Dec 1, 2022

Not sure if it's related to the changes that we made in this project, but the Add Security button does not work on this screen:

Screenshot 2022-12-01 at 11 58 47

@nunyvega
Copy link

nunyvega commented Dec 1, 2022

I see that VideoPress asks for a connection instead of showing the plan's price and a "Start for free" option. We can think about adding something like what Search has in a follow-up PR:

Screenshot 2022-12-01 at 12 05 28

@nunyvega
Copy link

nunyvega commented Dec 1, 2022

All the others products and cases that I tested worked as expected. Reviewing the code now

Copy link

@nunyvega nunyvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM

@oskosk oskosk modified the milestones: Jetpack 11.7, jetpack/11.6 Dec 2, 2022
Copy link
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oskosk oskosk enabled auto-merge (squash) December 2, 2022 16:18
@oskosk oskosk merged commit 9f80daa into trunk Dec 2, 2022
@sdixon194
Copy link
Contributor

sdixon194 commented Dec 2, 2022

Cherry picked and released new versions of My Jetpack 2.5.0.1 to all current release branches - Jetpack, Social, and Backup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment