-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
My Jetpack: Requires/Push to connection only if needed #27615
Conversation
Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run |
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. |
All the others products and cases that I tested worked as expected. Reviewing the code now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Cherry picked and released new versions of My Jetpack 2.5.0.1 to all current release branches - Jetpack, Social, and Backup. |
Closes #27608
Closes #27612
Closes #27611
Closes #27695
Changes proposed in this Pull Request:
connection
page only when activating and only if needed.ProductDetailCard
to useuseProductCheckoutWorkflow
.get_products_from_wpcom
to use endpoint based on user connection.Other information:
Jetpack product discussion
N/A
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
Fully Disconnected with Jetpack plugin
My Jetpack
.connect
screen first.Fully/User Disconnected with Standalone plugin
My Jetpack
.